Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(218)

Unified Diff: runtime/bin/BUILD.gn

Issue 2967673002: Restore -rdynamic in Product mode build (Closed)
Patch Set: Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/bin/BUILD.gn
diff --git a/runtime/bin/BUILD.gn b/runtime/bin/BUILD.gn
index 8de7a1b0a8c302a9ddad2128b315cade52c1130c..4d9ec19a196de318b672cdd215dbfe53b6bbe6a4 100644
--- a/runtime/bin/BUILD.gn
+++ b/runtime/bin/BUILD.gn
@@ -660,9 +660,9 @@ template("dart_executable") {
if (is_win) {
ldflags = [ "/EXPORT:Dart_True" ]
} else {
- if (dart_runtime_mode != "release") {
- ldflags = [ "-rdynamic" ]
- }
+ # Adds all symbols to the dynamic symbol table, not just used ones.
+ # This is needed to make native extensions work.
+ ldflags = [ "-rdynamic" ]
}
if (is_win) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698