Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Issue 2967603003: [devil] Fix bug in devil.android.tools.system_app_test (Closed)

Created:
3 years, 5 months ago by perezju
Modified:
3 years, 5 months ago
Reviewers:
jbudorick
CC:
catapult-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
catapult
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -0 lines) Patch
M devil/devil/android/tools/system_app_test.py View 1 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 10 (5 generated)
perezju
3 years, 5 months ago (2017-06-30 15:17:19 UTC) #2
jbudorick
lgtm Odd, this passes consistently for me as-is. https://codereview.chromium.org/2967603003/diff/1/devil/devil/android/tools/system_app_test.py File devil/devil/android/tools/system_app_test.py (right): https://codereview.chromium.org/2967603003/diff/1/devil/devil/android/tools/system_app_test.py#newcode35 devil/devil/android/tools/system_app_test.py:35: mock_device.build_version_sdk ...
3 years, 5 months ago (2017-07-05 14:16:52 UTC) #3
perezju
On 2017/07/05 14:16:52, jbudorick wrote: > lgtm > > Odd, this passes consistently for me ...
3 years, 5 months ago (2017-07-06 09:17:13 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967603003/20001
3 years, 5 months ago (2017-07-06 09:17:27 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 09:42:41 UTC) #10
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...

Powered by Google App Engine
This is Rietveld 408576698