Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(76)

Issue 2967493002: Relanding [Android] Adding Smart GO/NEXT feature in Chrome (Closed)

Created:
3 years, 5 months ago by AKVT
Modified:
3 years, 5 months ago
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, creis+watch_chromium.org, nasko+codewatch_chromium.org, jam, dglazkov+blink, darin-cc_chromium.org, agrieve+watch_chromium.org, blink-reviews, kinuko+watch, blink-reviews-api_chromium.org, platform-architecture-syd+reviews-web_chromium.org, Yaron, Ted C
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Relanding [Android] Adding Smart GO/NEXT feature in Chrome Smart Go/Next brings better user experience to the user during form submitting applications. For navigating between form elements, user can use NEXT/PREVIOUS button from IME without touching on individual fields. This will avoid unnecessary form submissions before filling or visiting all fields in the form. Additionally it will save user time and avoid redundant network requests before actually filling/attending entire fields in the form Design Document: https://docs.google.com/document/d/1h0diigZ8LUi7A3UKJ_zwNUbvNQoe-Nwr55_p6ivSPNg/edit?usp=sharing Initial patch is reviewed @ https://codereview.chromium.org/2839993002/ and https://codereview.chromium.org/2948593002/ Scrolling performance is getting effected due to call to NextFocusableElementInForm() from InputMethodController. hence splitting it into multiple patches. This is the initial landing without enabling functionality. In next patch functionality will be enabled with necessary test coverage. BUG=410785, 648986, 733222 Review-Url: https://codereview.chromium.org/2967493002 Cr-Commit-Position: refs/heads/master@{#484020} Committed: https://chromium.googlesource.com/chromium/src/+/933aca75233fbb5145c29c1e5a06e5f36c308cc0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+177 lines, -23 lines) Patch
M content/browser/android/ime_adapter_android.h View 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/android/ime_adapter_android.cc View 2 chunks +12 lines, -0 lines 0 comments Download
M content/common/frame_messages.h View 1 chunk +6 lines, -0 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeAdapter.java View 3 chunks +24 lines, -8 lines 0 comments Download
M content/public/android/java/src/org/chromium/content/browser/input/ImeUtils.java View 3 chunks +15 lines, -14 lines 0 comments Download
M content/renderer/render_frame_impl.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/renderer/render_frame_impl.cc View 3 chunks +8 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusController.cpp View 3 chunks +47 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/page/FocusControllerTest.cpp View 1 chunk +26 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.h View 1 chunk +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebLocalFrameImpl.cpp View 1 chunk +16 lines, -0 lines 0 comments Download
M third_party/WebKit/public/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebFocusType.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/public/platform/WebTextInputType.h View 1 chunk +3 lines, -1 line 0 comments Download
M third_party/WebKit/public/web/WebLocalFrame.h View 2 chunks +8 lines, -0 lines 0 comments Download

Messages

Total messages: 22 (10 generated)
AKVT
PTAL! This patch is initially reviewed @ https://codereview.chromium.org/2948593002/. Due to power regression, in this CL ...
3 years, 5 months ago (2017-06-29 18:11:07 UTC) #2
nasko
> Due to performance regression, splitting it into multiple patches. > This is the initial ...
3 years, 5 months ago (2017-06-29 18:46:38 UTC) #4
AKVT
On 2017/06/29 18:46:38, nasko (slow) wrote: > > Due to performance regression, splitting it into ...
3 years, 5 months ago (2017-06-29 19:32:55 UTC) #5
AKVT
kochi@, changwan@, tkent@, nasko@ - Could you PTAL. As discussed I will be enabling functionality ...
3 years, 5 months ago (2017-06-30 14:02:00 UTC) #6
nasko
On 2017/06/29 19:32:55, AKVT wrote: > On 2017/06/29 18:46:38, nasko (slow) wrote: > > > ...
3 years, 5 months ago (2017-06-30 17:18:38 UTC) #7
tkent
On 2017/06/30 at 14:02:00, ajith.v wrote: > kochi@, changwan@, tkent@, nasko@ - Could you PTAL. ...
3 years, 5 months ago (2017-07-02 22:55:03 UTC) #12
AKVT
changwan@ - Could you PTAL content/public changes again for landing initial patch ?
3 years, 5 months ago (2017-07-03 09:09:21 UTC) #13
Takayoshi Kochi (Google)
FocusController change LGTM changwan@, could you check Android-specific part?
3 years, 5 months ago (2017-07-03 09:09:37 UTC) #15
Changwan Ryu
On 2017/07/03 09:09:37, Takayoshi Kochi (Google) wrote: > FocusController change LGTM > > changwan@, could ...
3 years, 5 months ago (2017-07-03 09:33:01 UTC) #16
AKVT
On 2017/07/03 09:33:01, Changwan Ryu wrote: > On 2017/07/03 09:09:37, Takayoshi Kochi (Google) wrote: > ...
3 years, 5 months ago (2017-07-03 09:48:54 UTC) #17
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967493002/1
3 years, 5 months ago (2017-07-03 15:06:04 UTC) #19
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 17:05:48 UTC) #22
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/933aca75233fbb5145c29c1e5a06...

Powered by Google App Engine
This is Rietveld 408576698