[Extensions Bindings] Fix getPlatform() method

[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

This also removes the "chromeos touch" option, which was added
in https://codereview.chromium.org/7104002/, but is no longer
needed.

BUG=738178
Review-Url: https://codereview.chromium.org/2967443004
Cr-Commit-Position: refs/heads/master@{#485364}
Committed: https://chromium.googlesource.com/chromium/src/+/e194d022357de0597c1c7448852417a9559b0f0a

[Devlin, 2017-06-29 22:00:20]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 22:00:50]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 22:12:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 22:12:01]

Dry run: Try jobs failed on following builders:
  chromeos_daisy_chromium_compile_only_ng on master.tryserver.chromium.linux
(JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromeos_daisy_...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Devlin, 2017-06-30 02:01:44]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 02:02:02]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 03:13:47]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 03:13:51]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-07-07 01:43:20]

Description was changed from

==========
fix platform
BUG=
==========

to

==========
[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

BUG=None
==========

[Devlin, 2017-07-07 20:48:07]

The CQ bit was checked by rdevlin.cronin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-07 20:48:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-07 22:16:10]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-07 22:16:11]

Dry run: This issue passed the CQ dry run.

[Devlin, 2017-07-07 22:20:21]

Description was changed from

==========
[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

BUG=None
==========

to

==========
[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

BUG=738178
==========

[Devlin, 2017-07-07 22:20:36]

rdevlin.cronin@chromium.org changed reviewers:
+ jbroman@chromium.org, lazyboy@chromium.org

[Devlin, 2017-07-07 22:20:37]

Short one for y'all. :)

[lazyboy, 2017-07-07 23:09:26]

lgtm

https://codereview.chromium.org/2967443004/diff/40001/extensions/renderer/res...
File extensions/renderer/resources/binding.js (left):

https://codereview.chromium.org/2967443004/diff/40001/extensions/renderer/res...
extensions/renderer/resources/binding.js:93: [/CrOS Touch/, "chromeos touch"],
You're also removing "chromeos touch", which is unused as far as I understand.
Archeology gives me this:
https://codereview.chromium.org/7104002/diff/20002/chrome/common/extensions/a...

Mind updating the CL description to also say it removes "chromeos touch"?

[jbroman, 2017-07-10 14:53:26]

lgtm

[Devlin, 2017-07-10 18:32:06]

Description was changed from

==========
[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

BUG=738178
==========

to

==========
[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

This also removes the "chromeos touch" option, which was added
in https://codereview.chromium.org/7104002/, but is no longer
needed.

BUG=738178
==========

[Devlin, 2017-07-10 18:35:31]

https://codereview.chromium.org/2967443004/diff/40001/extensions/renderer/res...
File extensions/renderer/resources/binding.js (left):

https://codereview.chromium.org/2967443004/diff/40001/extensions/renderer/res...
extensions/renderer/resources/binding.js:93: [/CrOS Touch/, "chromeos touch"],
On 2017/07/07 23:09:26, lazyboy wrote:
> You're also removing "chromeos touch", which is unused as far as I understand.
> Archeology gives me this:
>
https://codereview.chromium.org/7104002/diff/20002/chrome/common/extensions/a...
> 
> Mind updating the CL description to also say it removes "chromeos touch"?

Good idea; done.

[Devlin, 2017-07-10 18:36:00]

The CQ bit was checked by rdevlin.cronin@chromium.org

[commit-bot: I haz the power, 2017-07-10 18:36:16]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-10 20:34:51]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1499711760323410,
"parent_rev": "c0b38ac76f83bf140c80d7b17556186baa2427f2", "commit_rev":
"e194d022357de0597c1c7448852417a9559b0f0a"}

[commit-bot: I haz the power, 2017-07-10 20:35:03]

Description was changed from

==========
[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

This also removes the "chromeos touch" option, which was added
in https://codereview.chromium.org/7104002/, but is no longer
needed.

BUG=738178
==========

to

==========
[Extensions Bindings] Fix getPlatform() method

bindings.js uses a method to determine the current platform,
but it relies on navigator.appVersion (and also regexes).
Replace this with a native alternative.

This also removes the "chromeos touch" option, which was added
in https://codereview.chromium.org/7104002/, but is no longer
needed.

BUG=738178

Review-Url: https://codereview.chromium.org/2967443004
Cr-Commit-Position: refs/heads/master@{#485364}
Committed:
https://chromium.googlesource.com/chromium/src/+/e194d022357de0597c1c74488524...
==========

[commit-bot: I haz the power, 2017-07-10 20:35:04]

Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/e194d022357de0597c1c74488524...