Issue 2967423002: Merge to M60: Check whether a text node may be about to be redistributed in ShouldUpdateLayoutByRea…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2967423002: Merge to M60: Check whether a text node may be about to be redistributed in ShouldUpdateLayoutByRea… (Closed)

Created:
3 years, 5 months ago by dmazzoni

Modified:
3 years, 5 months ago

Reviewers:

CC:
chromium-reviews, sof, eae+blinkwatch, blink-reviews-dom_chromium.org, dglazkov+blink, blink-reviews, rwlbuis

Target Ref:
refs/branch-heads/3112

Project:
chromium

Visibility:
Public.

Merge to M60: Check whether a text node may be about to be redistributed in ShouldUpdateLayoutByReattaching(). Prevents use-after-free when SetTextWithOffset is called with dirty distribution. BUG=726716 Review-Url: https://codereview.chromium.org/2913133002 Cr-Original-Commit-Position: refs/heads/master@{#476242} Review-Url: https://codereview.chromium.org/2967423002 . Cr-Commit-Position: refs/branch-heads/3112@{#533} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/986255635c4af811abecf049b18c0b978d3a5703

Created: 3 years, 5 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -0 lines)			Patch
	M	third_party/WebKit/Source/core/dom/Text.cpp	View		2 chunks	+6 lines, -0 lines	0 comments	Download

Total messages: 2 (1 generated)

dmazzoni

3 years, 5 months ago (2017-07-06 20:15:50 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
986255635c4af811abecf049b18c0b978d3a5703 (tree was closed).