scheduler: expose paused property of a Job.

scheduler: expose paused property of a Job.

Previously, I expected that whether Job is paused can be detected
from it's "current state" string.

However, I just burned 1 hour trying to understand why after calling
PauseJob job's state was still running. The answer is obvious -> latest
invocation was scheduled before my call PauseJob, and hence I just had
to wait.

I think having explicit paused field is actually a better idea, even
though it has a downside of confusing too if state="running" and
paused=true.

R=vadimsh@chromium.org
Bug: 712427
Review-Url: https://codereview.chromium.org/2967373004
Committed: https://github.com/luci/luci-go/commit/e39d552a742c975af28cc5a4b99dbabce6a6ef1d

[tandrii(chromium), 2017-07-06 19:59:02]

The CQ bit was checked by tandrii@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-06 19:59:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 20:06:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-06 20:06:02]

Dry run: This issue passed the CQ dry run.

[Vadim Sh., 2017-07-06 21:28:59]

lgtm

[tandrii(chromium), 2017-07-07 09:24:20]

The CQ bit was checked by tandrii@chromium.org

[commit-bot: I haz the power, 2017-07-07 09:24:28]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[tandrii(chromium), 2017-07-07 09:24:50]

Description was changed from

==========
scheduler: expose paused property of a Job.

Previously, I expected that whether Job is paused can be detected
from it's "current state" string.

However, I just burned 1 hour trying to understand why after calling
PauseJob it's state was still running. The answer is obvious -> latest
invocation was scheduled before my call PauseJob, and hence I just had
to wait.

I think having explicit paused field is actually a better idea, even
though it has a downside of confusing too if state="running" and
paused=true.

R=vadimsh@chromium.org
Bug: 712427
==========

to

==========
scheduler: expose paused property of a Job.

Previously, I expected that whether Job is paused can be detected
from it's "current state" string.

However, I just burned 1 hour trying to understand why after calling
PauseJob job's state was still running. The answer is obvious -> latest
invocation was scheduled before my call PauseJob, and hence I just had
to wait.

I think having explicit paused field is actually a better idea, even
though it has a downside of confusing too if state="running" and
paused=true.

R=vadimsh@chromium.org
Bug: 712427
==========

[commit-bot: I haz the power, 2017-07-07 09:29:29]

CQ is committing da patch.

Bot data: {"patchset_id": 1, "attempt_start_ts": 1499419460539170, "parent_rev":
"8315cf5fcf6a6048afd984cec0dc32a4027ff4da", "commit_rev":
"e39d552a742c975af28cc5a4b99dbabce6a6ef1d"}

[commit-bot: I haz the power, 2017-07-07 09:29:32]

Description was changed from

==========
scheduler: expose paused property of a Job.

Previously, I expected that whether Job is paused can be detected
from it's "current state" string.

However, I just burned 1 hour trying to understand why after calling
PauseJob job's state was still running. The answer is obvious -> latest
invocation was scheduled before my call PauseJob, and hence I just had
to wait.

I think having explicit paused field is actually a better idea, even
though it has a downside of confusing too if state="running" and
paused=true.

R=vadimsh@chromium.org
Bug: 712427
==========

to

==========
scheduler: expose paused property of a Job.

Previously, I expected that whether Job is paused can be detected
from it's "current state" string.

However, I just burned 1 hour trying to understand why after calling
PauseJob job's state was still running. The answer is obvious -> latest
invocation was scheduled before my call PauseJob, and hence I just had
to wait.

I think having explicit paused field is actually a better idea, even
though it has a downside of confusing too if state="running" and
paused=true.

R=vadimsh@chromium.org
Bug: 712427
Review-Url: https://codereview.chromium.org/2967373004
Committed:
https://github.com/luci/luci-go/commit/e39d552a742c975af28cc5a4b99dbabce6a6ef1d
==========

[commit-bot: I haz the power, 2017-07-07 09:29:33]

Committed patchset #1 (id:1) as
https://github.com/luci/luci-go/commit/e39d552a742c975af28cc5a4b99dbabce6a6ef1d