Fix ASSERT in JingleMessage::OrderedMessageQueue.

Fix ASSERT in JingleMessage::OrderedMessageQueue.

Session-initate messages doesn't go through
JingleSession::OnIncomingMessage()

We need to initialize the OrderedMessageQueue with the id of the
session-initiate message.

BUG=694083
Review-Url: https://codereview.chromium.org/2967213002
Cr-Commit-Position: refs/heads/master@{#484385}
Committed: https://chromium.googlesource.com/chromium/src/+/18a8dd58a06879fec5b97e682e3bc6e90899bbab

[kelvinp, 2017-07-05 17:55:08]

kelvinp@chromium.org changed reviewers:
+ sergeyu@chromium.org

[kelvinp, 2017-07-05 17:55:08]

PTAL

[Sergey Ulanov, 2017-07-05 18:00:15]

lgtm when my style nits are addressed

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
File remoting/protocol/jingle_session.cc (right):

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:119: void setInitialId(const std::string&
id);
SetInitialiId() please

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:131: void
JingleSession::OrderedMessageQueue::setInitialId(const std::string& id) {
Put this after OnIncomingMessage() so the order matches the order in class
declaration.

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:236: const std::string& id,
call it message_id.

[kelvinp, 2017-07-05 22:29:41]

FYI

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
File remoting/protocol/jingle_session.cc (right):

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:119: void setInitialId(const std::string&
id);
On 2017/07/05 18:00:14, Sergey Ulanov wrote:
> SetInitialiId() please

Done.

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:131: void
JingleSession::OrderedMessageQueue::setInitialId(const std::string& id) {
On 2017/07/05 18:00:14, Sergey Ulanov wrote:
> Put this after OnIncomingMessage() so the order matches the order in class
> declaration.

Done.

https://codereview.chromium.org/2967213002/diff/1/remoting/protocol/jingle_se...
remoting/protocol/jingle_session.cc:236: const std::string& id,
On 2017/07/05 18:00:14, Sergey Ulanov wrote:
> call it message_id.

Done.

[kelvinp, 2017-07-05 22:30:21]

The CQ bit was checked by kelvinp@chromium.org

[kelvinp, 2017-07-05 22:30:22]

The patchset sent to the CQ was uploaded after l-g-t-m from sergeyu@chromium.org
Link to the patchset: https://codereview.chromium.org/2967213002/#ps20001
(title: "Reviewer's feedback")

[commit-bot: I haz the power, 2017-07-05 22:31:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 00:12:30]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499293821655130,
"parent_rev": "bd3c81a07695b99a13116a4611e2cbbb8f5cb2b0", "commit_rev":
"1ccc4eed664dd8ca02310293721ce49d25d93c3e"}

[commit-bot: I haz the power, 2017-07-06 00:12:51]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499293821655130,
"parent_rev": "216b1a3e072f9e531abcf79600fa52fd729b1262", "commit_rev":
"3f28e7744784dac70d782614193bd7d06a239403"}

[commit-bot: I haz the power, 2017-07-06 00:13:08]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499293821655130,
"parent_rev": "6ef1492232a804ac0eda21c129f2c370280e90fb", "commit_rev":
"18a8dd58a06879fec5b97e682e3bc6e90899bbab"}

[commit-bot: I haz the power, 2017-07-06 00:13:28]

Description was changed from

==========
Fix ASSERT in JingleMessage::OrderedMessageQueue.

Session-initate messages doesn't go through
JingleSession::OnIncomingMessage()

We need to initialize the OrderedMessageQueue with the id of the
session-initiate message.

BUG=694083
==========

to

==========
Fix ASSERT in JingleMessage::OrderedMessageQueue.

Session-initate messages doesn't go through
JingleSession::OnIncomingMessage()

We need to initialize the OrderedMessageQueue with the id of the
session-initiate message.

BUG=694083

Review-Url: https://codereview.chromium.org/2967213002
Cr-Commit-Position: refs/heads/master@{#484385}
Committed:
https://chromium.googlesource.com/chromium/src/+/18a8dd58a06879fec5b97e682e3b...
==========

[commit-bot: I haz the power, 2017-07-06 00:13:29]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/18a8dd58a06879fec5b97e682e3b...