Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(374)

Issue 2967163003: Use cssvalue::CounterValue instead of blink::CSSCounterValue (Closed)

Created:
3 years, 5 months ago by Daniel Bratell
Modified:
3 years, 5 months ago
Reviewers:
fs
CC:
darktears, apavlov+blink_chromium.org, blink-reviews, blink-reviews-css, chromium-reviews, dglazkov+blink, rwlbuis
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Use cssvalue::CounterValue instead of blink::CSSCounterValue A cleanup patch used the wrong namespace for CSSCounterValue. It still works but it was not right. R=fs@opera.com Review-Url: https://codereview.chromium.org/2967163003 Cr-Commit-Position: refs/heads/master@{#484276} Committed: https://chromium.googlesource.com/chromium/src/+/8c5cb0618ca20039dffd729cc876508acc7bee17

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -3 lines) Patch
M third_party/WebKit/Source/core/css/properties/CSSPropertyAPIContent.cpp View 2 chunks +1 line, -3 lines 0 comments Download

Messages

Total messages: 10 (6 generated)
Daniel Bratell
3 years, 5 months ago (2017-07-05 13:28:32 UTC) #1
fs
lgtm
3 years, 5 months ago (2017-07-05 13:33:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967163003/1
3 years, 5 months ago (2017-07-05 13:35:58 UTC) #7
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 15:10:46 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/8c5cb0618ca20039dffd729cc876...

Powered by Google App Engine
This is Rietveld 408576698