Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(181)

Issue 2967133002: Fix memory leak in NotificationControlButtonsView (Closed)

Created:
3 years, 5 months ago by yoshiki
Modified:
3 years, 5 months ago
Reviewers:
yhanada
CC:
chromium-reviews, Peter Beverloo, mlamouri+watch-notifications_chromium.org, awdf+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix memory leak in NotificationControlButtonsView This leak was introduce by my previous commit (crrev.com/12cad72cd90108551c79ebde78ed564832478707). This patch fixes it. BUG=none Review-Url: https://codereview.chromium.org/2967133002 Cr-Commit-Position: refs/heads/master@{#484262} Committed: https://chromium.googlesource.com/chromium/src/+/2dcb04bd0ebabb001293f26a62177cf6ab875bd4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -18 lines) Patch
M ui/message_center/views/notification_control_buttons_view.h View 2 chunks +5 lines, -8 lines 0 comments Download
M ui/message_center/views/notification_control_buttons_view.cc View 4 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 14 (10 generated)
yhanada
lgtm
3 years, 5 months ago (2017-07-05 12:10:52 UTC) #5
yoshiki
Thanks!
3 years, 5 months ago (2017-07-05 12:26:03 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967133002/1
3 years, 5 months ago (2017-07-05 13:46:25 UTC) #11
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 13:51:16 UTC) #14
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/2dcb04bd0ebabb001293f26a6217...

Powered by Google App Engine
This is Rietveld 408576698