Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(403)

Issue 2967063002: Don't report 'custom' processes as untracked. (Closed)

Created:
3 years, 5 months ago by bcwhite
Modified:
3 years, 5 months ago
CC:
chromium-reviews, jam, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't report 'custom' processes as untracked. BUG=728322 Review-Url: https://codereview.chromium.org/2967063002 Cr-Commit-Position: refs/heads/master@{#485936} Committed: https://chromium.googlesource.com/chromium/src/+/c600ac1d2771eb57c0875a0a9fe6002238eb89fc

Patch Set 1 #

Patch Set 2 : rebased #

Patch Set 3 : record all untracked sub-processes in sparse histogram but renumber 'custom' ones #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -5 lines) Patch
M content/browser/browser_child_process_host_impl.cc View 1 2 1 chunk +7 lines, -3 lines 0 comments Download
M tools/metrics/histograms/enums.xml View 1 1 chunk +14 lines, -0 lines 0 comments Download
M tools/metrics/histograms/histograms.xml View 1 2 1 chunk +3 lines, -2 lines 0 comments Download

Messages

Total messages: 41 (26 generated)
bcwhite
3 years, 5 months ago (2017-07-04 15:46:11 UTC) #4
bcwhite
This what you have in mind?
3 years, 5 months ago (2017-07-10 13:58:03 UTC) #13
Alexei Svitkine (slow)
lgtm
3 years, 5 months ago (2017-07-10 14:58:55 UTC) #14
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967063002/40001
3 years, 5 months ago (2017-07-10 19:51:29 UTC) #18
bcwhite
darin@chromium.org: Please review changes in content/browser/browser_child_process_host_impl.cc
3 years, 5 months ago (2017-07-10 20:00:24 UTC) #20
bcwhite
-darin +avi For content/browser/...
3 years, 5 months ago (2017-07-10 21:14:22 UTC) #23
Avi (use Gerrit)
lgtm stampy stampy
3 years, 5 months ago (2017-07-10 21:19:15 UTC) #24
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967063002/40001
3 years, 5 months ago (2017-07-11 14:43:44 UTC) #26
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_ng/builds/496763)
3 years, 5 months ago (2017-07-11 15:43:36 UTC) #28
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967063002/40001
3 years, 5 months ago (2017-07-11 19:20:10 UTC) #30
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/425498)
3 years, 5 months ago (2017-07-11 20:44:23 UTC) #32
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967063002/40001
3 years, 5 months ago (2017-07-11 21:16:03 UTC) #34
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_TIMED_OUT, build has not started yet; ...
3 years, 5 months ago (2017-07-11 23:17:19 UTC) #36
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967063002/40001
3 years, 5 months ago (2017-07-12 12:52:33 UTC) #38
commit-bot: I haz the power
3 years, 5 months ago (2017-07-12 13:37:33 UTC) #41
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/c600ac1d2771eb57c0875a0a9fe6...

Powered by Google App Engine
This is Rietveld 408576698