Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(162)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 296703011: Change refs from ChromeSigninClient to base SigninClient class. (Closed)

Created:
6 years, 7 months ago by Mike Lerman
Modified:
6 years, 7 months ago
CC:
chromium-reviews, tim+watch_chromium.org, chromium-apps-reviews_chromium.org, maniscalco+watch_chromium.org, haitaol+watch_chromium.org, extensions-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Change refs from ChromeSigninClient to base SigninClient class. Refactor. BUG=357693 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272595

Patch Set 1 #

Patch Set 2 : Small tweak on signin_client.h #

Total comments: 2

Patch Set 3 : Comment #

Patch Set 4 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+61 lines, -23 lines) Patch
M chrome/browser/chrome_content_browser_client.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/extensions/browser_permissions_policy_delegate_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/signin/chrome_signin_client.h View 3 chunks +4 lines, -6 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client_factory.h View 1 chunk +3 lines, -3 lines 0 comments Download
M chrome/browser/signin/chrome_signin_client_factory.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/signin/signin_browsertest.cc View 1 2 3 3 chunks +3 lines, -3 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/sync/one_click_signin_helper_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download
M components/signin/core/browser/signin_client.h View 1 3 chunks +8 lines, -1 line 0 comments Download
M components/signin/core/browser/test_signin_client.h View 1 2 2 chunks +7 lines, -0 lines 0 comments Download
M components/signin/core/browser/test_signin_client.cc View 2 chunks +26 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
Mike Lerman
kalman@chromium.org: Please review changes in c/b/extensions rogerta@chromium.org: Please review changes in everything else!
6 years, 7 months ago (2014-05-22 20:42:14 UTC) #1
not at google - send to devlin
lgtm
6 years, 7 months ago (2014-05-22 20:45:23 UTC) #2
Roger Tawa OOO till Jul 10th
lgtm https://codereview.chromium.org/296703011/diff/20001/components/signin/core/browser/test_signin_client.h File components/signin/core/browser/test_signin_client.h (right): https://codereview.chromium.org/296703011/diff/20001/components/signin/core/browser/test_signin_client.h#newcode62 components/signin/core/browser/test_signin_client.h:62: virtual void SetSigninProcess(int host_id) OVERRIDE; nit comment: // ...
6 years, 7 months ago (2014-05-22 23:04:38 UTC) #3
Mike Lerman
https://codereview.chromium.org/296703011/diff/20001/components/signin/core/browser/test_signin_client.h File components/signin/core/browser/test_signin_client.h (right): https://codereview.chromium.org/296703011/diff/20001/components/signin/core/browser/test_signin_client.h#newcode62 components/signin/core/browser/test_signin_client.h:62: virtual void SetSigninProcess(int host_id) OVERRIDE; On 2014/05/22 23:04:38, Roger ...
6 years, 7 months ago (2014-05-23 12:40:57 UTC) #4
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 7 months ago (2014-05-23 15:55:31 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/296703011/40002
6 years, 7 months ago (2014-05-23 15:56:18 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-23 18:55:28 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-23 19:34:31 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/156631)
6 years, 7 months ago (2014-05-23 19:34:32 UTC) #9
Mike Lerman
The CQ bit was checked by mlerman@chromium.org
6 years, 7 months ago (2014-05-23 20:27:03 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mlerman@chromium.org/296703011/40002
6 years, 7 months ago (2014-05-23 20:28:15 UTC) #11
commit-bot: I haz the power
6 years, 7 months ago (2014-05-23 21:40:24 UTC) #12
Message was sent while issue was closed. 
Change committed as 272595

Powered by Google App Engine
This is Rietveld 408576698