chrome/browser/ui/sync/one_click_signin_helper.cc - Issue 296703011: Change refs from ChromeSigninClient to base SigninClient class.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/sync/one_click_signin_helper.cc

Issue 296703011: Change refs from ChromeSigninClient to base SigninClient class. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Rebase Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/ui/sync/one_click_signin_helper.cc

diff --git a/chrome/browser/ui/sync/one_click_signin_helper.cc b/chrome/browser/ui/sync/one_click_signin_helper.cc

index 7e4fdfe8633137c948948125295ef4ae983be972..8c063d9bb5bcce7be702a5a4f4639a5c0ba8d8e7 100644

--- a/chrome/browser/ui/sync/one_click_signin_helper.cc

+++ b/chrome/browser/ui/sync/one_click_signin_helper.cc

@@ -1105,7 +1105,7 @@ void OneClickSigninHelper::ShowInfoBarUIThread(

// show a modal dialog asking the user to confirm.

Profile* profile =

Profile::FromBrowserContext(web_contents->GetBrowserContext());

- ChromeSigninClient* signin_client =

+ SigninClient* signin_client =

profile ? ChromeSigninClientFactory::GetForProfile(profile) : NULL;

helper->untrusted_confirmation_required_ |=

(signin_client && !signin_client->IsSigninProcess(child_id));

@@ -1306,7 +1306,7 @@ void OneClickSigninHelper::DidNavigateMainFrame(

// sign-in process when a navigation to a non-sign-in URL occurs.

Profile* profile =

Profile::FromBrowserContext(web_contents()->GetBrowserContext());

- ChromeSigninClient* signin_client =

+ SigninClient* signin_client =

profile ? ChromeSigninClientFactory::GetForProfile(profile) : NULL;

int process_id = web_contents()->GetRenderProcessHost()->GetID();

if (signin_client && signin_client->IsSigninProcess(process_id))

« no previous file with comments | « chrome/browser/signin/signin_browsertest.cc ('k') | chrome/browser/ui/sync/one_click_signin_helper_unittest.cc » ('j') | no next file with comments »