Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(608)

Unified Diff: Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use LinkedHashSet for ElementSet instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h
diff --git a/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h b/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h
index f6c65b7a0e2b1f180c873197e26641f1b05b8247..a4dc2210cc6f5d443823853d2089a5b9f9ac5ab8 100644
--- a/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h
+++ b/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h
@@ -33,6 +33,7 @@
#include "core/dom/custom/CustomElementDescriptor.h"
#include "core/dom/custom/CustomElementMicrotaskStep.h"
+#include "platform/heap/Handle.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/PassRefPtr.h"
#include "wtf/RefPtr.h"
@@ -45,12 +46,14 @@ class Element;
class CustomElementMicrotaskResolutionStep : public CustomElementMicrotaskStep {
WTF_MAKE_NONCOPYABLE(CustomElementMicrotaskResolutionStep);
public:
- static PassOwnPtr<CustomElementMicrotaskResolutionStep> create(PassRefPtr<CustomElementRegistrationContext>, PassRefPtr<Element>, const CustomElementDescriptor&);
+ static PassOwnPtrWillBeRawPtr<CustomElementMicrotaskResolutionStep> create(PassRefPtrWillBeRawPtr<CustomElementRegistrationContext>, PassRefPtrWillBeRawPtr<Element>, const CustomElementDescriptor&);
virtual ~CustomElementMicrotaskResolutionStep();
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
- CustomElementMicrotaskResolutionStep(PassRefPtr<CustomElementRegistrationContext>, PassRefPtr<Element>, const CustomElementDescriptor&);
+ CustomElementMicrotaskResolutionStep(PassRefPtrWillBeRawPtr<CustomElementRegistrationContext>, PassRefPtrWillBeRawPtr<Element>, const CustomElementDescriptor&);
virtual Result process() OVERRIDE;
virtual bool needsProcessOrStop() const OVERRIDE;
@@ -59,8 +62,8 @@ private:
virtual void show(unsigned indent) OVERRIDE;
#endif
- RefPtr<CustomElementRegistrationContext> m_context;
- RefPtr<Element> m_element;
+ RefPtrWillBeMember<CustomElementRegistrationContext> m_context;
+ RefPtrWillBeMember<Element> m_element;
CustomElementDescriptor m_descriptor;
haraken 2014/05/26 15:40:23 You need to trace this one, or you can simply drop
sof 2014/05/26 16:41:08 If the object doesn't have any Members (CustomElem
};

Powered by Google App Engine
This is Rietveld 408576698