Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(179)

Side by Side Diff: Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use LinkedHashSet for ElementSet instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 15 matching lines...) Expand all
26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT 26 * THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT
27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE 27 * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE
28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. 28 * OF THIS SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE.
29 */ 29 */
30 30
31 #ifndef CustomElementMicrotaskResolutionStep_h 31 #ifndef CustomElementMicrotaskResolutionStep_h
32 #define CustomElementMicrotaskResolutionStep_h 32 #define CustomElementMicrotaskResolutionStep_h
33 33
34 #include "core/dom/custom/CustomElementDescriptor.h" 34 #include "core/dom/custom/CustomElementDescriptor.h"
35 #include "core/dom/custom/CustomElementMicrotaskStep.h" 35 #include "core/dom/custom/CustomElementMicrotaskStep.h"
36 #include "platform/heap/Handle.h"
36 #include "wtf/PassOwnPtr.h" 37 #include "wtf/PassOwnPtr.h"
37 #include "wtf/PassRefPtr.h" 38 #include "wtf/PassRefPtr.h"
38 #include "wtf/RefPtr.h" 39 #include "wtf/RefPtr.h"
39 40
40 namespace WebCore { 41 namespace WebCore {
41 42
42 class CustomElementRegistrationContext; 43 class CustomElementRegistrationContext;
43 class Element; 44 class Element;
44 45
45 class CustomElementMicrotaskResolutionStep : public CustomElementMicrotaskStep { 46 class CustomElementMicrotaskResolutionStep : public CustomElementMicrotaskStep {
46 WTF_MAKE_NONCOPYABLE(CustomElementMicrotaskResolutionStep); 47 WTF_MAKE_NONCOPYABLE(CustomElementMicrotaskResolutionStep);
47 public: 48 public:
48 static PassOwnPtr<CustomElementMicrotaskResolutionStep> create(PassRefPtr<Cu stomElementRegistrationContext>, PassRefPtr<Element>, const CustomElementDescrip tor&); 49 static PassOwnPtrWillBeRawPtr<CustomElementMicrotaskResolutionStep> create(P assRefPtrWillBeRawPtr<CustomElementRegistrationContext>, PassRefPtrWillBeRawPtr< Element>, const CustomElementDescriptor&);
49 50
50 virtual ~CustomElementMicrotaskResolutionStep(); 51 virtual ~CustomElementMicrotaskResolutionStep();
51 52
53 virtual void trace(Visitor*) OVERRIDE;
54
52 private: 55 private:
53 CustomElementMicrotaskResolutionStep(PassRefPtr<CustomElementRegistrationCon text>, PassRefPtr<Element>, const CustomElementDescriptor&); 56 CustomElementMicrotaskResolutionStep(PassRefPtrWillBeRawPtr<CustomElementReg istrationContext>, PassRefPtrWillBeRawPtr<Element>, const CustomElementDescripto r&);
54 57
55 virtual Result process() OVERRIDE; 58 virtual Result process() OVERRIDE;
56 virtual bool needsProcessOrStop() const OVERRIDE; 59 virtual bool needsProcessOrStop() const OVERRIDE;
57 60
58 #if !defined(NDEBUG) 61 #if !defined(NDEBUG)
59 virtual void show(unsigned indent) OVERRIDE; 62 virtual void show(unsigned indent) OVERRIDE;
60 #endif 63 #endif
61 64
62 RefPtr<CustomElementRegistrationContext> m_context; 65 RefPtrWillBeMember<CustomElementRegistrationContext> m_context;
63 RefPtr<Element> m_element; 66 RefPtrWillBeMember<Element> m_element;
64 CustomElementDescriptor m_descriptor; 67 CustomElementDescriptor m_descriptor;
haraken 2014/05/26 15:40:23 You need to trace this one, or you can simply drop
sof 2014/05/26 16:41:08 If the object doesn't have any Members (CustomElem
65 }; 68 };
66 69
67 } 70 }
68 71
69 #endif // CustomElementMicrotaskResolutionStep_h 72 #endif // CustomElementMicrotaskResolutionStep_h
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698