Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(626)

Unified Diff: Source/core/dom/custom/CustomElementMicrotaskImportStep.h

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Use LinkedHashSet for ElementSet instead. Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/core/dom/custom/CustomElementMicrotaskImportStep.h
diff --git a/Source/core/dom/custom/CustomElementMicrotaskImportStep.h b/Source/core/dom/custom/CustomElementMicrotaskImportStep.h
index 124f1726715998a7fe4a4525e08cc9dc1be344c4..e7b1597dc698a9dbddc62b3c5805d9c75fbc816f 100644
--- a/Source/core/dom/custom/CustomElementMicrotaskImportStep.h
+++ b/Source/core/dom/custom/CustomElementMicrotaskImportStep.h
@@ -32,6 +32,7 @@
#define CustomElementMicrotaskImportStep_h
#include "core/dom/custom/CustomElementMicrotaskStep.h"
+#include "platform/heap/Handle.h"
#include "wtf/Noncopyable.h"
#include "wtf/PassOwnPtr.h"
#include "wtf/PassRefPtr.h"
@@ -52,7 +53,7 @@ class HTMLImportChild;
class CustomElementMicrotaskImportStep : public CustomElementMicrotaskStep {
WTF_MAKE_NONCOPYABLE(CustomElementMicrotaskImportStep);
public:
- static PassOwnPtr<CustomElementMicrotaskImportStep> create(HTMLImportChild*);
+ static PassOwnPtrWillBeRawPtr<CustomElementMicrotaskImportStep> create(HTMLImportChild*);
virtual ~CustomElementMicrotaskImportStep();
// API for HTML Imports
@@ -60,8 +61,10 @@ public:
void importDidFinishLoading();
WeakPtr<CustomElementMicrotaskImportStep> weakPtr() { return m_weakFactory.createWeakPtr(); }
+ virtual void trace(Visitor*) OVERRIDE;
+
private:
- CustomElementMicrotaskImportStep(HTMLImportChild*);
+ explicit CustomElementMicrotaskImportStep(HTMLImportChild*);
void didUpgradeAllCustomElements();
bool shouldWaitForImport() const;
@@ -75,7 +78,7 @@ private:
virtual void show(unsigned indent) OVERRIDE;
#endif
WeakPtr<HTMLImportChild> m_import;
- RefPtr<CustomElementMicrotaskQueue> m_queue;
+ RefPtrWillBeMember<CustomElementMicrotaskQueue> m_queue;
WeakPtrFactory<CustomElementMicrotaskImportStep> m_weakFactory;
};

Powered by Google App Engine
This is Rietveld 408576698