Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp - Issue 296703009: Oilpan: move custom element objects to the heap.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Fix compilation issue pointed out by clang Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h ('k') | Source/core/dom/custom/CustomElementMicrotaskStep.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

diff --git a/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp b/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

index 1dce4a531cfe4402416370045b820e4a4a8bf32d..a926f95a3f1e38d165e89a91087ecd28e5cadff7 100644

--- a/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

+++ b/Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

@@ -36,12 +36,12 @@

namespace WebCore {

-PassOwnPtr<CustomElementMicrotaskResolutionStep> CustomElementMicrotaskResolutionStep::create(PassRefPtr<CustomElementRegistrationContext> context, PassRefPtr<Element> element, const CustomElementDescriptor& descriptor)

+PassOwnPtrWillBeRawPtr<CustomElementMicrotaskResolutionStep> CustomElementMicrotaskResolutionStep::create(PassRefPtrWillBeRawPtr<CustomElementRegistrationContext> context, PassRefPtrWillBeRawPtr<Element> element, const CustomElementDescriptor& descriptor)

{

- return adoptPtr(new CustomElementMicrotaskResolutionStep(context, element, descriptor));

+ return adoptPtrWillBeNoop(new CustomElementMicrotaskResolutionStep(context, element, descriptor));

}

-CustomElementMicrotaskResolutionStep::CustomElementMicrotaskResolutionStep(PassRefPtr<CustomElementRegistrationContext> context, PassRefPtr<Element> element, const CustomElementDescriptor& descriptor)

+CustomElementMicrotaskResolutionStep::CustomElementMicrotaskResolutionStep(PassRefPtrWillBeRawPtr<CustomElementRegistrationContext> context, PassRefPtrWillBeRawPtr<Element> element, const CustomElementDescriptor& descriptor)

: m_context(context)

, m_element(element)

, m_descriptor(descriptor)

@@ -63,6 +63,13 @@ bool CustomElementMicrotaskResolutionStep::needsProcessOrStop() const

return true;

}

+void CustomElementMicrotaskResolutionStep::trace(Visitor* visitor)

+ visitor->trace(m_context);

+ visitor->trace(m_element);

+ CustomElementMicrotaskStep::trace(visitor);

#if !defined(NDEBUG)

void CustomElementMicrotaskResolutionStep::show(unsigned indent)

{