Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(246)

Side by Side Diff: Source/core/dom/custom/CustomElementMicrotaskResolutionStep.cpp

Issue 296703009: Oilpan: move custom element objects to the heap. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Fix compilation issue pointed out by clang Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 18 matching lines...) Expand all
29 */ 29 */
30 30
31 #include "config.h" 31 #include "config.h"
32 #include "core/dom/custom/CustomElementMicrotaskResolutionStep.h" 32 #include "core/dom/custom/CustomElementMicrotaskResolutionStep.h"
33 33
34 #include "core/dom/Element.h" 34 #include "core/dom/Element.h"
35 #include "core/dom/custom/CustomElementRegistrationContext.h" 35 #include "core/dom/custom/CustomElementRegistrationContext.h"
36 36
37 namespace WebCore { 37 namespace WebCore {
38 38
39 PassOwnPtr<CustomElementMicrotaskResolutionStep> CustomElementMicrotaskResolutio nStep::create(PassRefPtr<CustomElementRegistrationContext> context, PassRefPtr<E lement> element, const CustomElementDescriptor& descriptor) 39 PassOwnPtrWillBeRawPtr<CustomElementMicrotaskResolutionStep> CustomElementMicrot askResolutionStep::create(PassRefPtrWillBeRawPtr<CustomElementRegistrationContex t> context, PassRefPtrWillBeRawPtr<Element> element, const CustomElementDescript or& descriptor)
40 { 40 {
41 return adoptPtr(new CustomElementMicrotaskResolutionStep(context, element, d escriptor)); 41 return adoptPtrWillBeNoop(new CustomElementMicrotaskResolutionStep(context, element, descriptor));
42 } 42 }
43 43
44 CustomElementMicrotaskResolutionStep::CustomElementMicrotaskResolutionStep(PassR efPtr<CustomElementRegistrationContext> context, PassRefPtr<Element> element, co nst CustomElementDescriptor& descriptor) 44 CustomElementMicrotaskResolutionStep::CustomElementMicrotaskResolutionStep(PassR efPtrWillBeRawPtr<CustomElementRegistrationContext> context, PassRefPtrWillBeRaw Ptr<Element> element, const CustomElementDescriptor& descriptor)
45 : m_context(context) 45 : m_context(context)
46 , m_element(element) 46 , m_element(element)
47 , m_descriptor(descriptor) 47 , m_descriptor(descriptor)
48 { 48 {
49 } 49 }
50 50
51 CustomElementMicrotaskResolutionStep::~CustomElementMicrotaskResolutionStep() 51 CustomElementMicrotaskResolutionStep::~CustomElementMicrotaskResolutionStep()
52 { 52 {
53 } 53 }
54 54
55 CustomElementMicrotaskStep::Result CustomElementMicrotaskResolutionStep::process () 55 CustomElementMicrotaskStep::Result CustomElementMicrotaskResolutionStep::process ()
56 { 56 {
57 m_context->resolve(m_element.get(), m_descriptor); 57 m_context->resolve(m_element.get(), m_descriptor);
58 return CustomElementMicrotaskStep::ContinueWithRemoving; 58 return CustomElementMicrotaskStep::ContinueWithRemoving;
59 } 59 }
60 60
61 bool CustomElementMicrotaskResolutionStep::needsProcessOrStop() const 61 bool CustomElementMicrotaskResolutionStep::needsProcessOrStop() const
62 { 62 {
63 return true; 63 return true;
64 } 64 }
65 65
66 void CustomElementMicrotaskResolutionStep::trace(Visitor* visitor)
67 {
68 visitor->trace(m_context);
69 visitor->trace(m_element);
70 CustomElementMicrotaskStep::trace(visitor);
71 }
72
66 #if !defined(NDEBUG) 73 #if !defined(NDEBUG)
67 void CustomElementMicrotaskResolutionStep::show(unsigned indent) 74 void CustomElementMicrotaskResolutionStep::show(unsigned indent)
68 { 75 {
69 fprintf(stderr, "%*sResolution: ", indent, ""); 76 fprintf(stderr, "%*sResolution: ", indent, "");
70 m_element->outerHTML().show(); 77 m_element->outerHTML().show();
71 } 78 }
72 #endif 79 #endif
73 80
74 } // namespace WebCore 81 } // namespace WebCore
OLDNEW
« no previous file with comments | « Source/core/dom/custom/CustomElementMicrotaskResolutionStep.h ('k') | Source/core/dom/custom/CustomElementMicrotaskStep.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698