 Chromium Code Reviews
 Chromium Code Reviews Issue 296703009:
  Oilpan: move custom element objects to the heap.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master
    
  
    Issue 296703009:
  Oilpan: move custom element objects to the heap.  (Closed) 
  Base URL: https://chromium.googlesource.com/chromium/blink.git@master| Index: Source/core/dom/DocumentInit.h | 
| diff --git a/Source/core/dom/DocumentInit.h b/Source/core/dom/DocumentInit.h | 
| index 087301d67094ae5587ec968fb3d495560e18fd4b..ffe4e9293cacc1d16874a681048dbddc7b441bdf 100644 | 
| --- a/Source/core/dom/DocumentInit.h | 
| +++ b/Source/core/dom/DocumentInit.h | 
| @@ -30,6 +30,7 @@ | 
| #include "core/dom/SandboxFlags.h" | 
| #include "core/dom/SecurityContext.h" | 
| +#include "platform/heap/Handle.h" | 
| #include "platform/weborigin/KURL.h" | 
| #include "wtf/PassRefPtr.h" | 
| #include "wtf/RefPtr.h" | 
| @@ -43,7 +44,8 @@ class LocalFrame; | 
| class HTMLImportsController; | 
| class Settings; | 
| -class DocumentInit { | 
| +class DocumentInit FINAL { | 
| + STACK_ALLOCATED(); | 
| public: | 
| explicit DocumentInit(const KURL& = KURL(), LocalFrame* = 0, WeakPtr<Document> = WeakPtr<Document>(), HTMLImportsController* = 0); | 
| DocumentInit(const DocumentInit&); | 
| @@ -67,7 +69,7 @@ public: | 
| DocumentInit& withRegistrationContext(CustomElementRegistrationContext*); | 
| DocumentInit& withNewRegistrationContext(); | 
| - PassRefPtr<CustomElementRegistrationContext> registrationContext(Document*) const; | 
| + PassRefPtrWillBeRawPtr<CustomElementRegistrationContext> registrationContext(Document*) const; | 
| WeakPtr<Document> contextDocument() const; | 
| static DocumentInit fromContext(WeakPtr<Document> contextDocument, const KURL& = KURL()); | 
| @@ -80,8 +82,8 @@ private: | 
| RefPtr<Document> m_parent; | 
| RefPtr<Document> m_owner; | 
| WeakPtr<Document> m_contextDocument; | 
| 
haraken
2014/05/22 08:24:10
Not related to your CL, but this looks strange to
 
sof
2014/05/26 15:46:18
Will follow up on this separately (along with the
 | 
| - HTMLImportsController* m_importsController; | 
| - RefPtr<CustomElementRegistrationContext> m_registrationContext; | 
| + RawPtrWillBeMember<HTMLImportsController> m_importsController; | 
| + RefPtrWillBeMember<CustomElementRegistrationContext> m_registrationContext; | 
| bool m_createNewRegistrationContext; | 
| }; |