Oilpan: move custom element objects to the heap.

Source/core/dom/DocumentInit.h

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2006 Alexey Proskuryakov (ap@webkit.org)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012 Apple Inc. All rights reserved.
  * Copyright (C) 2008, 2009 Torch Mobile Inc. All rights reserved. (http://www.torchmobile.com/)
  * Copyright (C) 2010 Nokia Corporation and/or its subsidiary(-ies)
  * Copyright (C) 2013 Google Inc. All rights reserved.
  *
@@ skipping 12 matching lines @@
  * the Free Software Foundation, Inc., 51 Franklin Street, Fifth Floor,
  * Boston, MA 02110-1301, USA.
  *
  */
 
 #ifndef DocumentInit_h
 #define DocumentInit_h
 
 #include "core/dom/SandboxFlags.h"
 #include "core/dom/SecurityContext.h"
+#include "platform/heap/Handle.h"
 #include "platform/weborigin/KURL.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefPtr.h"
 #include "wtf/WeakPtr.h"
 
 namespace WebCore {
 
 class CustomElementRegistrationContext;
 class Document;
 class LocalFrame;
 class HTMLImportsController;
 class Settings;
 
-class DocumentInit {
+class DocumentInit FINAL {
+    STACK_ALLOCATED();
 public:
     explicit DocumentInit(const KURL& = KURL(), LocalFrame* = 0, WeakPtr<Document> = WeakPtr<Document>(), HTMLImportsController* = 0);
     DocumentInit(const DocumentInit&);
     ~DocumentInit();
 
     const KURL& url() const { return m_url; }
     LocalFrame* frame() const { return m_frame; }
     HTMLImportsController* importsController() const { return m_importsController; }
 
     bool hasSecurityContext() const { return frameForSecurityContext(); }
     bool shouldTreatURLAsSrcdocDocument() const;
     bool shouldSetURL() const;
     bool isSeamlessAllowedFor(Document* child) const;
     SandboxFlags sandboxFlags() const;
 
     Document* parent() const { return m_parent.get(); }
     Document* owner() const { return m_owner.get(); }
     KURL parentBaseURL() const;
     LocalFrame* ownerFrame() const;
     Settings* settings() const;
 
     DocumentInit& withRegistrationContext(CustomElementRegistrationContext*);
     DocumentInit& withNewRegistrationContext();
-    PassRefPtr<CustomElementRegistrationContext> registrationContext(Document*) const;
+    PassRefPtrWillBeRawPtr<CustomElementRegistrationContext> registrationContext(Document*) const;
     WeakPtr<Document> contextDocument() const;
 
     static DocumentInit fromContext(WeakPtr<Document> contextDocument, const KURL& = KURL());
 
 private:
     LocalFrame* frameForSecurityContext() const;
 
     KURL m_url;
     LocalFrame* m_frame;
     RefPtr<Document> m_parent;
     RefPtr<Document> m_owner;
     WeakPtr<Document> m_contextDocument;

[haraken, 2014/05/22 08:24:10]

Not related to your CL, but this looks strange to me. Why do we want to use a
WeakPtr in an on-stack object?

[sof, 2014/05/26 15:46:18]

Will follow up on this separately (along with the other occurrences of
Document.)

-    HTMLImportsController* m_importsController;
-    RefPtr<CustomElementRegistrationContext> m_registrationContext;
+    RawPtrWillBeMember<HTMLImportsController> m_importsController;
+    RefPtrWillBeMember<CustomElementRegistrationContext> m_registrationContext;
     bool m_createNewRegistrationContext;
 };
 
 } // namespace WebCore
 
 #endif // DocumentInit_h