Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(201)

Issue 296703008: Revert 271798 "[Metrics] Make MetricsStateManager take a callbac..." (Closed)

Created:
6 years, 7 months ago by Sam McNally
Modified:
6 years, 7 months ago
Reviewers:
Ilya Sherman
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 271798 "[Metrics] Make MetricsStateManager take a callbac..." Breaks Google Chrome Linux x64 compile: http://build.chromium.org/p/chromium.chrome/buildstatus?builder=Google%20Chrome%20Linux%20x64&number=50183 > [Metrics] Make MetricsStateManager take a callback param to check if UMA is enabled. > > Also, remove a no longer needed testing pref. > > BUG=374296 > TEST=compiles > R=asvitkine@chromium.org > > Review URL: https://codereview.chromium.org/284293003 TBR=isherman@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271822

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+58 lines, -93 lines) Patch
M trunk/src/chrome/browser/metrics/metrics_service_unittest.cc View 4 chunks +7 lines, -13 lines 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_services_manager.h View 1 chunk +0 lines, -3 lines 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_services_manager.cc View 2 chunks +2 lines, -34 lines 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_state_manager.h View 5 chunks +8 lines, -14 lines 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_state_manager.cc View 4 chunks +29 lines, -11 lines 0 comments Download
M trunk/src/chrome/browser/metrics/metrics_state_manager_unittest.cc View 3 chunks +5 lines, -18 lines 0 comments Download
M trunk/src/chrome/common/chrome_switches.h View 1 chunk +1 line, -0 lines 0 comments Download
M trunk/src/chrome/common/chrome_switches.cc View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Sam McNally
6 years, 7 months ago (2014-05-21 02:56:53 UTC) #1
Sam McNally
6 years, 7 months ago (2014-05-21 02:57:25 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r271822 (tree was closed).

Powered by Google App Engine
This is Rietveld 408576698