Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(519)

Unified Diff: trunk/src/chrome/browser/metrics/metrics_state_manager_unittest.cc

Issue 296703008: Revert 271798 "[Metrics] Make MetricsStateManager take a callbac..." (Closed) Base URL: svn://svn.chromium.org/chrome/
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: trunk/src/chrome/browser/metrics/metrics_state_manager_unittest.cc
===================================================================
--- trunk/src/chrome/browser/metrics/metrics_state_manager_unittest.cc (revision 271821)
+++ trunk/src/chrome/browser/metrics/metrics_state_manager_unittest.cc (working copy)
@@ -7,7 +7,6 @@
#include <ctype.h>
#include <string>
-#include "base/bind.h"
#include "base/command_line.h"
#include "base/prefs/testing_pref_service.h"
#include "chrome/common/chrome_switches.h"
@@ -20,32 +19,18 @@
class MetricsStateManagerTest : public testing::Test {
public:
- MetricsStateManagerTest() : is_metrics_reporting_enabled_(false) {
+ MetricsStateManagerTest() {
MetricsStateManager::RegisterPrefs(prefs_.registry());
}
scoped_ptr<MetricsStateManager> CreateStateManager() {
- return MetricsStateManager::Create(
- &prefs_,
- base::Bind(&MetricsStateManagerTest::is_metrics_reporting_enabled,
- base::Unretained(this))).Pass();
+ return MetricsStateManager::Create(&prefs_).Pass();
}
- // Sets metrics reporting as enabled for testing.
- void EnableMetricsReporting() {
- is_metrics_reporting_enabled_ = true;
- }
-
protected:
TestingPrefServiceSimple prefs_;
private:
- bool is_metrics_reporting_enabled() const {
- return is_metrics_reporting_enabled_;
- }
-
- bool is_metrics_reporting_enabled_;
-
DISALLOW_COPY_AND_ASSIGN(MetricsStateManagerTest);
};
@@ -74,7 +59,9 @@
}
TEST_F(MetricsStateManagerTest, EntropySourceUsed_High) {
- EnableMetricsReporting();
+ CommandLine::ForCurrentProcess()->AppendSwitch(
+ switches::kEnableMetricsReportingForTesting);
+
scoped_ptr<MetricsStateManager> state_manager(CreateStateManager());
state_manager->CreateEntropyProvider();
EXPECT_EQ(MetricsStateManager::ENTROPY_SOURCE_HIGH,
« no previous file with comments | « trunk/src/chrome/browser/metrics/metrics_state_manager.cc ('k') | trunk/src/chrome/common/chrome_switches.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698