Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(107)

Issue 2967023002: android: Add thread time to early TraceEvent, make timings more precise. (Closed)

Created:
3 years, 5 months ago by Benoit L
Modified:
3 years, 5 months ago
CC:
chromium-reviews, tracing+reviews_chromium.org, wfh+watch_chromium.org, danakj+watch_chromium.org, agrieve+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Add thread time to early TraceEvent, make timings more precise. This CL allows early trace events to show thread time in addition to wall clock time. For instance, on a Nexus 5X running N, this shows that the first framework-created "android.view.Choreographer$FrameHandler" task is largely spent blocked. Also, on Android >= JB MR1, improve the resolution of timings from ms to us. For JB, keep the same resolution. Review-Url: https://codereview.chromium.org/2967023002 Cr-Commit-Position: refs/heads/master@{#486381} Committed: https://chromium.googlesource.com/chromium/src/+/5e25326cbba818417b7b4c5cf769a1c09ba80417

Patch Set 1 #

Patch Set 2 : . #

Total comments: 3

Patch Set 3 : Comment. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -31 lines) Patch
M base/android/early_trace_event_binding.cc View 1 chunk +14 lines, -14 lines 0 comments Download
M base/android/java/src/org/chromium/base/EarlyTraceEvent.java View 3 chunks +30 lines, -13 lines 0 comments Download
M base/trace_event/trace_event.h View 1 2 chunks +36 lines, -0 lines 0 comments Download
M base/trace_event/trace_log.h View 1 chunk +7 lines, -0 lines 0 comments Download
M base/trace_event/trace_log.cc View 1 2 1 chunk +14 lines, -4 lines 0 comments Download

Messages

Total messages: 25 (18 generated)
Benoit L
Hi, Since startup time is gathering more interest lately, especially in the context of Android ...
3 years, 5 months ago (2017-07-07 14:34:27 UTC) #6
Primiano Tucci (use gerrit)
cool LGTM w/ just a micro nit. I can see the pain of having to ...
3 years, 5 months ago (2017-07-10 13:09:15 UTC) #11
Benoit L
Thanks! +rmcilroy for base/android OWNERS. PTAL, thanks. https://codereview.chromium.org/2967023002/diff/20001/base/trace_event/trace_log.cc File base/trace_event/trace_log.cc (right): https://codereview.chromium.org/2967023002/diff/20001/base/trace_event/trace_log.cc#newcode1386 base/trace_event/trace_log.cc:1386: UpdateTraceEventDurationExplicit(category_group_enabled, name, ...
3 years, 5 months ago (2017-07-10 13:39:54 UTC) #13
Benoit L
On 2017/07/10 13:39:54, Benoit L wrote: > Thanks! > > +rmcilroy for base/android OWNERS. > ...
3 years, 5 months ago (2017-07-13 08:48:46 UTC) #14
rmcilroy
Sorry thought I'd already LGTMed this for some reason. LGTM
3 years, 5 months ago (2017-07-13 09:30:57 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2967023002/40001
3 years, 5 months ago (2017-07-13 14:54:14 UTC) #22
commit-bot: I haz the power
3 years, 5 months ago (2017-07-13 14:59:25 UTC) #25
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/5e25326cbba818417b7b4c5cf769...

Powered by Google App Engine
This is Rietveld 408576698