Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(31)

Issue 2966973002: Reland: Expand EditableLine to include non-inline text box leafs (Closed)

Created:
3 years, 5 months ago by David Tseng
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews, alemate+watch_chromium.org, dtseng+watch_chromium.org, aboxhall+watch_chromium.org, nektar+watch_chromium.org, yuzo+watch_chromium.org, dougt+watch_chromium.org, dmazzoni+watch_chromium.org, oshima+watch_chromium.org, aleventhal+watch_chromium.org, je_julie, arv+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Expand EditableLine to include non-inline text box leafs Original issue: https://codereview.chromium.org/2965683002/ BUG=719654 TBR=dtseng@chromium.org CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation Review-Url: https://codereview.chromium.org/2966973002 Cr-Commit-Position: refs/heads/master@{#484026} Committed: https://chromium.googlesource.com/chromium/src/+/b29061177e782976f0a271510c6939c67529be35

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -19 lines) Patch
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing.js View 3 chunks +30 lines, -19 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/editing_test.extjs View 1 chunk +56 lines, -0 lines 0 comments Download
M chrome/browser/resources/chromeos/chromevox/cvox2/background/output.js View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 15 (11 generated)
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966973002/1
3 years, 5 months ago (2017-07-03 14:17:35 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_ozone_rel_ng on master.tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_ozone_rel_ng/builds/420011)
3 years, 5 months ago (2017-07-03 15:43:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966973002/1
3 years, 5 months ago (2017-07-03 18:24:44 UTC) #12
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 18:28:39 UTC) #15
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/b29061177e782976f0a271510c69...

Powered by Google App Engine
This is Rietveld 408576698