Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issue 296693003: Don't treat |is_directory| mismatch as an error in entry conversion in files.app. (Closed)

Created:
6 years, 7 months ago by kinaba
Modified:
6 years, 7 months ago
Reviewers:
hirono
CC:
chromium-reviews, nkostylev+watch_chromium.org, yoshiki+watch_chromium.org, rginda+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Don't treat |is_directory| mismatch as an error in entry conversion in files.app. BUG=374722 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271656

Patch Set 1 #

Patch Set 2 : Review fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -23 lines) Patch
M chrome/browser/chromeos/extensions/file_manager/event_router.cc View 1 1 chunk +4 lines, -3 lines 0 comments Download
M chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc View 1 1 chunk +5 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/file_manager/fileapi_util.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/chromeos/file_manager/fileapi_util.cc View 1 chunk +11 lines, -19 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
kinaba
After all, I realized that the check should be just removed. WDYT?
6 years, 7 months ago (2014-05-20 05:06:20 UTC) #1
hirono
On 2014/05/20 05:06:20, kinaba wrote: > After all, I realized that the check should be ...
6 years, 7 months ago (2014-05-20 06:28:55 UTC) #2
kinaba
On 2014/05/20 06:28:55, hirono wrote: > On 2014/05/20 05:06:20, kinaba wrote: > > After all, ...
6 years, 7 months ago (2014-05-20 06:56:27 UTC) #3
hirono
On 2014/05/20 06:56:27, kinaba wrote: > On 2014/05/20 06:28:55, hirono wrote: > > On 2014/05/20 ...
6 years, 7 months ago (2014-05-20 07:04:15 UTC) #4
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-20 07:05:16 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/296693003/20001
6 years, 7 months ago (2014-05-20 07:05:52 UTC) #6
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 09:58:56 UTC) #7
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-20 11:22:39 UTC) #8
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/155333)
6 years, 7 months ago (2014-05-20 11:22:40 UTC) #9
kinaba
The CQ bit was checked by kinaba@chromium.org
6 years, 7 months ago (2014-05-20 12:44:16 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/kinaba@chromium.org/296693003/20001
6 years, 7 months ago (2014-05-20 12:45:01 UTC) #11
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-20 13:40:07 UTC) #12
commit-bot: I haz the power
6 years, 7 months ago (2014-05-20 15:28:18 UTC) #13
Message was sent while issue was closed.
Change committed as 271656

Powered by Google App Engine
This is Rietveld 408576698