chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc - Issue 296693003: Don't treat |is_directory| mismatch as an error in entry conversion in files.app.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

Issue 296693003: Don't treat |is_directory| mismatch as an error in entry conversion in files.app. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Review fix Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/chromeos/extensions/file_manager/event_router.cc ('k') | chrome/browser/chromeos/file_manager/fileapi_util.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

diff --git a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

index 6ffbf2c10141cc0d1ddc8d33459fd727ef282340..e3fd264f795d82b528fca1fbda38a7efb6ddd360 100644

--- a/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

+++ b/chrome/browser/chromeos/extensions/file_manager/private_api_file_system.cc

@@ -326,6 +326,11 @@ void FileBrowserPrivateRequestFileSystemFunction::OnEntryDefinition(

return;

}

+ if (!entry_definition.is_directory) {

+ DidFail(base::File::FILE_ERROR_NOT_A_DIRECTORY);

+ return;

+ }

base::DictionaryValue* dict = new base::DictionaryValue();

SetResult(dict);

dict->SetString("name", entry_definition.file_system_name);