Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(74)

Issue 2966843002: Fix host browser picking dialogs hanging after dismiss. (Closed)

Created:
3 years, 5 months ago by Xi Han
Modified:
3 years, 5 months ago
Reviewers:
Yaron
CC:
chromium-reviews, zpeng+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix host browser picking dialogs hanging after dismiss. Set a listener for OnDismiss events. BUG=738504 Review-Url: https://codereview.chromium.org/2966843002 Cr-Commit-Position: refs/heads/master@{#483811} Committed: https://chromium.googlesource.com/chromium/src/+/dcfac70ed37adf7f16a305f1e8b0287d796764d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -1 line) Patch
M chrome/android/webapk/shell_apk/shell_apk_version.gni View 1 chunk +1 line, -1 line 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/ChooseHostBrowserDialog.java View 1 chunk +6 lines, -0 lines 0 comments Download
M chrome/android/webapk/shell_apk/src/org/chromium/webapk/shell_apk/InstallHostBrowserDialog.java View 1 chunk +6 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
Xi Han
Hi Yaron, could you please take a look? Thanks!
3 years, 5 months ago (2017-06-30 18:37:19 UTC) #3
Yaron
lgtm
3 years, 5 months ago (2017-06-30 18:48:54 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966843002/1
3 years, 5 months ago (2017-06-30 18:49:13 UTC) #6
commit-bot: I haz the power
3 years, 5 months ago (2017-06-30 20:46:34 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/dcfac70ed37adf7f16a305f1e8b0...

Powered by Google App Engine
This is Rietveld 408576698