Add support for bounds animations

Add support for bounds animations

With this cl, we now support animating bounds (an interpolation of
gfx::SizeF).

BUG=738644
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2966723003
Cr-Commit-Position: refs/heads/master@{#484129}
Committed: https://chromium.googlesource.com/chromium/src/+/09d5967b99632e5674ce510d80b99f739ddf69fb

[Ian Vollick, 2017-07-01 03:20:12]

Description was changed from

==========
Add support for bounds animations

With this cl, we now support animating bounds (an interpolation of
gfx::SizeF).

BUG=
==========

to

==========
Add support for bounds animations

With this cl, we now support animating bounds (an interpolation of
gfx::SizeF).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Ian Vollick, 2017-07-01 03:20:19]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 03:20:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2017-07-01 03:24:03]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 03:24:07]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Ian Vollick, 2017-07-01 03:28:55]

Description was changed from

==========
Add support for bounds animations

With this cl, we now support animating bounds (an interpolation of
gfx::SizeF).

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add support for bounds animations

With this cl, we now support animating bounds (an interpolation of
gfx::SizeF).

BUG=738644
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

[Ian Vollick, 2017-07-01 03:28:55]

vollick@chromium.org changed reviewers:
+ ajuma@chromium.org, danakj@chromium.org

[Ian Vollick, 2017-07-01 03:33:44]

On 2017/07/01 03:28:55, Ian Vollick wrote:
> mailto:vollick@chromium.org changed reviewers:
> + mailto:ajuma@chromium.org, mailto:danakj@chromium.org

Ali, Rob, hopefully this is in line with what we'd discussed earlier.

Dana, please ping me if you'd like more context.

+ajuma for everything,
+danakj for ui/gfx,
+flackr for whatever you'd like! (In particular, please let me know if this is
out of line with what threaded rendering is up to).

[Ian Vollick, 2017-07-01 04:04:14]

The CQ bit was checked by vollick@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 04:04:17]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 05:32:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 05:32:01]

Dry run: This issue passed the CQ dry run.

[ajuma, 2017-07-04 14:13:36]

lgtm

https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_...
File cc/animation/keyframed_animation_curve_unittest.cc (right):

https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_...
cc/animation/keyframed_animation_curve_unittest.cc:989: // Tests that a color
animation with one keyframe works as expected.
"size animation"

https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_...
cc/animation/keyframed_animation_curve_unittest.cc:1026: gfx::SizeF size_c =
gfx::SizeF(100, 0);
nit: Make size_c != size_b.

[Ian Vollick, 2017-07-04 14:31:05]

Thanks for the review!

https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_...
File cc/animation/keyframed_animation_curve_unittest.cc (right):

https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_...
cc/animation/keyframed_animation_curve_unittest.cc:989: // Tests that a color
animation with one keyframe works as expected.
On 2017/07/04 14:13:36, ajuma wrote:
> "size animation"

Done.

https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_...
cc/animation/keyframed_animation_curve_unittest.cc:1026: gfx::SizeF size_c =
gfx::SizeF(100, 0);
On 2017/07/04 14:13:36, ajuma wrote:
> nit: Make size_c != size_b.

Done.

[danakj, 2017-07-04 15:20:19]

LGTM

[Ian Vollick, 2017-07-04 15:22:58]

The CQ bit was checked by vollick@chromium.org

[Ian Vollick, 2017-07-04 15:22:58]

The patchset sent to the CQ was uploaded after l-g-t-m from ajuma@chromium.org
Link to the patchset: https://codereview.chromium.org/2966723003/#ps60001
(title: "address reviewer feedback")

[commit-bot: I haz the power, 2017-07-04 15:23:08]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 16:40:13]

CQ is committing da patch.

Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499181778310930,
"parent_rev": "71caea00e82ec943d5488296635f0cc720cf13a5", "commit_rev":
"09d5967b99632e5674ce510d80b99f739ddf69fb"}

[commit-bot: I haz the power, 2017-07-04 16:40:30]

Description was changed from

==========
Add support for bounds animations

With this cl, we now support animating bounds (an interpolation of
gfx::SizeF).

BUG=738644
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel
==========

to

==========
Add support for bounds animations

With this cl, we now support animating bounds (an interpolation of
gfx::SizeF).

BUG=738644
CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel

Review-Url: https://codereview.chromium.org/2966723003
Cr-Commit-Position: refs/heads/master@{#484129}
Committed:
https://chromium.googlesource.com/chromium/src/+/09d5967b99632e5674ce510d80b9...
==========

[commit-bot: I haz the power, 2017-07-04 16:40:31]

Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/09d5967b99632e5674ce510d80b9...