Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2966723003: Add support for bounds animations (Closed)

Created:
3 years, 5 months ago by Ian Vollick
Modified:
3 years, 5 months ago
Reviewers:
danakj, ajuma
CC:
chromium-reviews, cc-bugs_chromium.org, flackr
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for bounds animations With this cl, we now support animating bounds (an interpolation of gfx::SizeF). BUG=738644 CQ_INCLUDE_TRYBOTS=master.tryserver.blink:linux_trusty_blink_rel Review-Url: https://codereview.chromium.org/2966723003 Cr-Commit-Position: refs/heads/master@{#484129} Committed: https://chromium.googlesource.com/chromium/src/+/09d5967b99632e5674ce510d80b99f739ddf69fb

Patch Set 1 #

Patch Set 2 : . #

Patch Set 3 : Added another unit test to confirm that extrapolation won't lead to invalid sizes. #

Total comments: 4

Patch Set 4 : address reviewer feedback #

Unified diffs Side-by-side diffs Delta from patch set Stats (+339 lines, -5 lines) Patch
M cc/animation/animation_curve.h View 4 chunks +14 lines, -1 line 0 comments Download
M cc/animation/animation_curve.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/animation/animation_player.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M cc/animation/element_animations.h View 2 chunks +5 lines, -0 lines 0 comments Download
M cc/animation/element_animations.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M cc/animation/keyframed_animation_curve.h View 3 chunks +57 lines, -0 lines 0 comments Download
M cc/animation/keyframed_animation_curve.cc View 3 chunks +77 lines, -2 lines 0 comments Download
M cc/animation/keyframed_animation_curve_unittest.cc View 1 2 3 1 chunk +88 lines, -0 lines 0 comments Download
M cc/trees/target_property.h View 1 chunk +2 lines, -1 line 0 comments Download
M cc/trees/target_property.cc View 1 chunk +2 lines, -1 line 0 comments Download
M ui/gfx/animation/tween.h View 2 chunks +5 lines, -0 lines 0 comments Download
M ui/gfx/animation/tween.cc View 1 chunk +9 lines, -0 lines 0 comments Download
M ui/gfx/animation/tween_unittest.cc View 1 2 1 chunk +31 lines, -0 lines 0 comments Download
M ui/gfx/test/gfx_util.h View 2 chunks +8 lines, -0 lines 0 comments Download
M ui/gfx/test/gfx_util.cc View 1 chunk +13 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (15 generated)
Ian Vollick
On 2017/07/01 03:28:55, Ian Vollick wrote: > mailto:vollick@chromium.org changed reviewers: > + mailto:ajuma@chromium.org, mailto:danakj@chromium.org Ali, ...
3 years, 5 months ago (2017-07-01 03:33:44 UTC) #8
ajuma
lgtm https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_animation_curve_unittest.cc File cc/animation/keyframed_animation_curve_unittest.cc (right): https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_animation_curve_unittest.cc#newcode989 cc/animation/keyframed_animation_curve_unittest.cc:989: // Tests that a color animation with one ...
3 years, 5 months ago (2017-07-04 14:13:36 UTC) #13
Ian Vollick
Thanks for the review! https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_animation_curve_unittest.cc File cc/animation/keyframed_animation_curve_unittest.cc (right): https://codereview.chromium.org/2966723003/diff/40001/cc/animation/keyframed_animation_curve_unittest.cc#newcode989 cc/animation/keyframed_animation_curve_unittest.cc:989: // Tests that a color ...
3 years, 5 months ago (2017-07-04 14:31:05 UTC) #14
danakj
LGTM
3 years, 5 months ago (2017-07-04 15:20:19 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966723003/60001
3 years, 5 months ago (2017-07-04 15:23:08 UTC) #18
commit-bot: I haz the power
3 years, 5 months ago (2017-07-04 16:40:31 UTC) #21
Message was sent while issue was closed.
Committed patchset #4 (id:60001) as
https://chromium.googlesource.com/chromium/src/+/09d5967b99632e5674ce510d80b9...

Powered by Google App Engine
This is Rietveld 408576698