VS 2017 Update 3 Preview 3 with fixed SDK

VS 2017 Update 3 Preview 3 with fixed SDK

This change switches the VS 2017 package to use the 10.0.15063.468 SDK and
the third preview of VS 2017 Update 3.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 3,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.15063.468 SDK installer was used to install the Debuggers
package and patch wrl\event.h (still broken in the SDK installed by VS
2017 Updat3 3).

The packaging script was run like this:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w 10.0.15063.0

VS 2015 builds are still the default so this makes no immediate difference.

R=dpranke@chromium.org
BUG=683729
Review-Url: https://codereview.chromium.org/2966713003
Cr-Commit-Position: refs/heads/master@{#484715}
Committed: https://chromium.googlesource.com/chromium/src/+/9da63a8364a4cdec18db79b537ac819d29dd4284

[brucedawson, 2017-07-01 01:11:23]

The CQ bit was checked by brucedawson@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-01 01:11:32]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-01 02:41:45]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-01 02:41:46]

Dry run: This issue passed the CQ dry run.

[brucedawson, 2017-07-05 17:43:23]

Description was changed from

==========
VS 2017 Update 3 Preview 3 with fixed SDK

BUG=683729
==========

to

==========
VS 2017 Update 3 Preview 3 with fixed SDK

This change switches the VS 2017 package to use the 10.0.15063.468 SDK and
the third preview of VS 2017 Update 3.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 3,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.15063.468 SDK installer was used to install the Debuggers
package and patch wrl\event.h (still broken in the SDK installed by VS
2017 Updat3 3).

The packaging script was run like this:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.15063.0

VS 2015 builds are still the default so this makes no immediate difference.

R=dpranke@chromium.org
BUG=683729
==========

[brucedawson, 2017-07-05 17:43:23]

brucedawson@chromium.org changed reviewers:
+ dpranke@chromium.org

[brucedawson, 2017-07-05 17:45:46]

Try bots passed with default temporarily set to VS 2017. Actual change to be
committed will not change the default but will allow continued testing with VS
2017.

[Dirk Pranke, 2017-07-06 02:32:04]

rs- lgtm.

[brucedawson, 2017-07-06 17:59:27]

The CQ bit was checked by brucedawson@chromium.org

[commit-bot: I haz the power, 2017-07-06 17:59:38]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-06 19:38:37]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499363967635280,
"parent_rev": "e9ef9bcc4612961297396109e5444ccfb7b88dfb", "commit_rev":
"9da63a8364a4cdec18db79b537ac819d29dd4284"}

[commit-bot: I haz the power, 2017-07-06 19:38:47]

Description was changed from

==========
VS 2017 Update 3 Preview 3 with fixed SDK

This change switches the VS 2017 package to use the 10.0.15063.468 SDK and
the third preview of VS 2017 Update 3.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 3,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.15063.468 SDK installer was used to install the Debuggers
package and patch wrl\event.h (still broken in the SDK installed by VS
2017 Updat3 3).

The packaging script was run like this:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.15063.0

VS 2015 builds are still the default so this makes no immediate difference.

R=dpranke@chromium.org
BUG=683729
==========

to

==========
VS 2017 Update 3 Preview 3 with fixed SDK

This change switches the VS 2017 package to use the 10.0.15063.468 SDK and
the third preview of VS 2017 Update 3.

Packaging was done on a Windows Server 2016 VM, cleanly created for this
purpose.

Compiler was packaged up by downloading the VS 2017 Update 3 Preview 3,
from https://www.visualstudio.com/vs/preview/, and then running this
command (executable name was different):

    vs_professional.exe --add Microsoft.VisualStudio.Workload.NativeDesktop
    --add Microsoft.VisualStudio.Component.VC.ATLMFC --includeRecommended
    --passive

Then the Windows 10.0.15063.468 SDK installer was used to install the Debuggers
package and patch wrl\event.h (still broken in the SDK installed by VS
2017 Updat3 3).

The packaging script was run like this:

    python depot_tools\win_toolchain\package_from_installed.py 2017 -w
10.0.15063.0

VS 2015 builds are still the default so this makes no immediate difference.

R=dpranke@chromium.org
BUG=683729

Review-Url: https://codereview.chromium.org/2966713003
Cr-Commit-Position: refs/heads/master@{#484715}
Committed:
https://chromium.googlesource.com/chromium/src/+/9da63a8364a4cdec18db79b537ac...
==========

[commit-bot: I haz the power, 2017-07-06 19:38:48]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9da63a8364a4cdec18db79b537ac...