Move overflow indicator to notifiction header.

Move overflow indicator to notifiction header.

In list notification of new-style notification, overflow indicator was
shown on the right bottom of the notification. Now this is moved to the
notification header so that it is compatible with the mock.
This CL also adds divider string between the title and the message of a
list notification sub item.

BUG=726244
TEST=manual

Review-Url: https://codereview.chromium.org/2966693002
Cr-Commit-Position: refs/heads/master@{#483967}
Committed: https://chromium.googlesource.com/chromium/src/+/2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6

[tetsui, 2017-06-30 05:25:31]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 05:25:35]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 06:38:55]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 06:38:56]

Dry run: This issue passed the CQ dry run.

[tetsui, 2017-06-30 06:52:53]

tetsui@chromium.org changed reviewers:
+ fukino@chromium.org, yoshiki@chromium.org

[tetsui, 2017-06-30 06:52:53]

PTAL. Thanks!

[yoshiki, 2017-07-03 07:27:21]

lgtm nits

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_view_md.cc (right):

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_view_md.cc:762: : list_items_count_ -
kMaxLinesForMessageView);
nit: "list_items_count_ - (expanded ? item_views_.size() :
kMaxLineForMessageView)" should be simpler.

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_view_md.h (right):

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_view_md.h:89: int list_items_count_ = 0;
nit: please add a brief explanation of this variable.

[tetsui, 2017-07-03 07:36:00]

yoshiki@: Thank you for reviewing!

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_view_md.cc (right):

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_view_md.cc:762: : list_items_count_ -
kMaxLinesForMessageView);
On 2017/07/03 07:27:20, yoshiki wrote:
> nit: "list_items_count_ - (expanded ? item_views_.size() :
> kMaxLineForMessageView)" should be simpler.

Done.

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
File ui/message_center/views/notification_view_md.h (right):

https://codereview.chromium.org/2966693002/diff/1/ui/message_center/views/not...
ui/message_center/views/notification_view_md.h:89: int list_items_count_ = 0;
On 2017/07/03 07:27:20, yoshiki wrote:
> nit: please add a brief explanation of this variable.

Done.

[tetsui, 2017-07-03 07:36:09]

The CQ bit was checked by tetsui@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-07-03 07:36:18]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 08:50:57]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 08:50:58]

Dry run: This issue passed the CQ dry run.

[tetsui, 2017-07-03 09:03:42]

The CQ bit was checked by tetsui@chromium.org

[tetsui, 2017-07-03 09:03:42]

The patchset sent to the CQ was uploaded after l-g-t-m from yoshiki@chromium.org
Link to the patchset: https://codereview.chromium.org/2966693002/#ps20001
(title: "Resolve review comments.")

[commit-bot: I haz the power, 2017-07-03 09:03:49]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 09:13:35]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499072622543820,
"parent_rev": "7b5ce1cef2f229a824b7bc1b9607899c8428f455", "commit_rev":
"2d4cc5fead9061144164995f65a2b633db3ed70f"}

[commit-bot: I haz the power, 2017-07-03 09:13:49]

CQ is committing da patch.

Bot data: {"patchset_id": 20001, "attempt_start_ts": 1499072622543820,
"parent_rev": "cdc8aa0a5d25c6bd0eb0ec9c9b14c3a94e28528b", "commit_rev":
"2f0bd13b3cf5ac9b2794dc4b30f3d3bb5271c8f6"}

[commit-bot: I haz the power, 2017-07-03 09:14:04]

Description was changed from

==========
Move overflow indicator to notifiction header.

In list notification of new-style notification, overflow indicator was
shown on the right bottom of the notification. Now this is moved to the
notification header so that it is compatible with the mock.
This CL also adds divider string between the title and the message of a
list notification sub item.

BUG=726244
TEST=manual
==========

to

==========
Move overflow indicator to notifiction header.

In list notification of new-style notification, overflow indicator was
shown on the right bottom of the notification. Now this is moved to the
notification header so that it is compatible with the mock.
This CL also adds divider string between the title and the message of a
list notification sub item.

BUG=726244
TEST=manual

Review-Url: https://codereview.chromium.org/2966693002
Cr-Commit-Position: refs/heads/master@{#483967}
Committed:
https://chromium.googlesource.com/chromium/src/+/2f0bd13b3cf5ac9b2794dc4b30f3...
==========

[commit-bot: I haz the power, 2017-07-03 09:14:05]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/2f0bd13b3cf5ac9b2794dc4b30f3...