Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 2966643002: media: Plumb MediaLog to MojoVideoDecoderService. (Closed)

Created:
3 years, 5 months ago by sandersd (OOO until July 31)
Modified:
3 years, 5 months ago
Reviewers:
xhwang, nasko
CC:
chromium-reviews, qsr+mojo_chromium.org, feature-media-reviews_chromium.org, posciak+watch_chromium.org, viettrungluu+watch_chromium.org, jam, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin-cc_chromium.org, alokp+watch_chromium.org, darin (slow to review)
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

media: Plumb MediaLog to MojoVideoDecoderService. BUG=512916 Review-Url: https://codereview.chromium.org/2966643002 Cr-Commit-Position: refs/heads/master@{#485119} Committed: https://chromium.googlesource.com/chromium/src/+/57073e98df6de1e11fe54da6ca0047f62c78c12e

Patch Set 1 #

Total comments: 9

Patch Set 2 : Add MediaLog::id(). #

Patch Set 3 : Swap client/service directory. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+237 lines, -43 lines) Patch
M content/common/view_messages.h View 3 chunks +0 lines, -10 lines 0 comments Download
M media/base/decoder_factory.h View 2 chunks +2 lines, -0 lines 0 comments Download
M media/base/decoder_factory.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/base/ipc/media_param_traits_macros.h View 4 chunks +19 lines, -8 lines 0 comments Download
M media/base/media_log.h View 1 1 chunk +4 lines, -0 lines 0 comments Download
M media/mojo/clients/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_decoder_factory.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/clients/mojo_decoder_factory.cc View 1 chunk +2 lines, -1 line 0 comments Download
A media/mojo/clients/mojo_media_log_service.h View 1 2 1 chunk +33 lines, -0 lines 0 comments Download
A media/mojo/clients/mojo_media_log_service.cc View 1 2 1 chunk +40 lines, -0 lines 0 comments Download
M media/mojo/clients/mojo_video_decoder.h View 1 2 4 chunks +6 lines, -1 line 0 comments Download
M media/mojo/clients/mojo_video_decoder.cc View 3 chunks +9 lines, -4 lines 0 comments Download
M media/mojo/interfaces/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
A media/mojo/interfaces/media_log.mojom View 1 chunk +11 lines, -0 lines 0 comments Download
M media/mojo/interfaces/media_types.mojom View 3 chunks +18 lines, -14 lines 0 comments Download
M media/mojo/interfaces/media_types.typemap View 2 chunks +2 lines, -0 lines 0 comments Download
M media/mojo/interfaces/video_decoder.mojom View 2 chunks +2 lines, -0 lines 0 comments Download
M media/mojo/services/BUILD.gn View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
M media/mojo/services/gpu_mojo_media_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/gpu_mojo_media_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_media_client.h View 1 chunk +1 line, -0 lines 0 comments Download
M media/mojo/services/mojo_media_client.cc View 1 chunk +1 line, -0 lines 0 comments Download
A media/mojo/services/mojo_media_log.h View 1 2 1 chunk +35 lines, -0 lines 0 comments Download
A media/mojo/services/mojo_media_log.cc View 1 2 1 chunk +28 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_video_decoder_service.h View 3 chunks +3 lines, -0 lines 0 comments Download
M media/mojo/services/mojo_video_decoder_service.cc View 1 2 3 chunks +11 lines, -4 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 21 (8 generated)
sandersd (OOO until July 31)
3 years, 5 months ago (2017-06-29 22:45:29 UTC) #2
sandersd (OOO until July 31)
nasko@: Please review changes in //media/mojo/interfaces.
3 years, 5 months ago (2017-06-29 23:50:17 UTC) #4
sandersd (OOO until July 31)
On 2017/06/29 23:50:17, sandersd wrote: > nasko@: Please review changes in //media/mojo/interfaces. Also //media/base/ipc.
3 years, 5 months ago (2017-06-29 23:51:29 UTC) #5
xhwang
Thank you for working on this! Looking pretty good. I just have a few comments. ...
3 years, 5 months ago (2017-06-30 16:24:57 UTC) #6
nasko
The pure IPC parts look fine, but I found the code really hard to follow ...
3 years, 5 months ago (2017-06-30 17:10:59 UTC) #7
sandersd (OOO until July 31)
https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn File media/mojo/clients/BUILD.gn (right): https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn#newcode38 media/mojo/clients/BUILD.gn:38: "mojo_media_log.h", On 2017/06/30 16:24:57, xhwang wrote: > This is ...
3 years, 5 months ago (2017-06-30 17:44:30 UTC) #8
xhwang
https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn File media/mojo/clients/BUILD.gn (right): https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn#newcode38 media/mojo/clients/BUILD.gn:38: "mojo_media_log.h", On 2017/06/30 17:44:30, sandersd wrote: > On 2017/06/30 ...
3 years, 5 months ago (2017-06-30 19:54:24 UTC) #9
sandersd (OOO until July 31)
https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn File media/mojo/clients/BUILD.gn (right): https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn#newcode38 media/mojo/clients/BUILD.gn:38: "mojo_media_log.h", > I see your point and I admit ...
3 years, 5 months ago (2017-07-06 21:25:24 UTC) #10
xhwang
On 2017/07/06 21:25:24, sandersd wrote: > https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn > File media/mojo/clients/BUILD.gn (right): > > https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn#newcode38 > ...
3 years, 5 months ago (2017-07-07 07:14:28 UTC) #11
sandersd (OOO until July 31)
https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn File media/mojo/clients/BUILD.gn (right): https://codereview.chromium.org/2966643002/diff/1/media/mojo/clients/BUILD.gn#newcode38 media/mojo/clients/BUILD.gn:38: "mojo_media_log.h", On 2017/07/06 21:25:24, sandersd wrote: > > I ...
3 years, 5 months ago (2017-07-07 21:48:47 UTC) #12
xhwang
lgtm
3 years, 5 months ago (2017-07-07 21:54:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966643002/40001
3 years, 5 months ago (2017-07-07 21:59:24 UTC) #16
commit-bot: I haz the power
3 years, 5 months ago (2017-07-08 00:45:46 UTC) #21
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/57073e98df6de1e11fe54da6ca00...

Powered by Google App Engine
This is Rietveld 408576698