Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1032)

Unified Diff: runtime/vm/malloc_hooks_test.cc

Issue 2966593002: Updated native memory allocation profiling to use its own sample buffer instead of sharing a sample… (Closed)
Patch Set: Updated native memory allocation profiling to use its own sample buffer instead of sharing a sample… Created 3 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « runtime/vm/malloc_hooks_tcmalloc.cc ('k') | runtime/vm/profiler.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/malloc_hooks_test.cc
diff --git a/runtime/vm/malloc_hooks_test.cc b/runtime/vm/malloc_hooks_test.cc
index c51e74fc8e3fc960ccba0498e8653ffa3bea62b0..38ed39555bf7d6577813e87810f6d15dc1de112b 100644
--- a/runtime/vm/malloc_hooks_test.cc
+++ b/runtime/vm/malloc_hooks_test.cc
@@ -29,6 +29,7 @@ static void MallocHookTestBufferInitializer(volatile char* buffer,
UNIT_TEST_CASE(BasicMallocHookTest) {
bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
FLAG_profiler_native_memory = true;
+ Profiler::InitAllocationSampleBuffer();
MallocHooks::InitOnce();
MallocHooks::ResetStats();
@@ -54,6 +55,7 @@ UNIT_TEST_CASE(BasicMallocHookTest) {
UNIT_TEST_CASE(FreeUnseenMemoryMallocHookTest) {
bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
FLAG_profiler_native_memory = true;
+ Profiler::InitAllocationSampleBuffer();
MallocHooks::InitOnce();
const intptr_t pre_hook_buffer_size = 3;
@@ -90,6 +92,7 @@ UNIT_TEST_CASE(FreeUnseenMemoryMallocHookTest) {
VM_UNIT_TEST_CASE(StackTraceMallocHookSimpleTest) {
bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
FLAG_profiler_native_memory = true;
+ Profiler::InitAllocationSampleBuffer();
MallocHooks::InitOnce();
MallocHooks::ResetStats();
@@ -121,6 +124,7 @@ static char* DART_NOINLINE StackTraceLengthHelper(uintptr_t* end_address) {
VM_UNIT_TEST_CASE(StackTraceMallocHookLengthTest) {
bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
FLAG_profiler_native_memory = true;
+ Profiler::InitAllocationSampleBuffer();
uintptr_t test_start_address =
reinterpret_cast<uintptr_t>(Dart_TestStackTraceMallocHookLengthTest);
@@ -175,6 +179,7 @@ VM_UNIT_TEST_CASE(StackTraceMallocHookLengthTest) {
ISOLATE_UNIT_TEST_CASE(StackTraceMallocHookSimpleJSONTest) {
bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
FLAG_profiler_native_memory = true;
+ Profiler::InitAllocationSampleBuffer();
MallocHooks::InitOnce();
MallocHooks::ResetStats();
« no previous file with comments | « runtime/vm/malloc_hooks_tcmalloc.cc ('k') | runtime/vm/profiler.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698