Updated native memory allocation profiling to use its own sample buffer instead of sharing a sample…

runtime/vm/malloc_hooks_test.cc

 // Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "platform/globals.h"
 
 #if defined(DART_USE_TCMALLOC) && !defined(PRODUCT) && !defined(TARGET_ARCH_DBC)
 
 #include "platform/assert.h"
 #include "vm/globals.h"
@@ skipping 11 matching lines @@
   // in buffer isn't touched, the tcmalloc hooks won't be called.
   for (uintptr_t i = 0; i < size; ++i) {
     buffer[i] = i;
   }
 }
 
 
 UNIT_TEST_CASE(BasicMallocHookTest) {
   bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
   FLAG_profiler_native_memory = true;
+  Profiler::InitAllocationSampleBuffer();
 
   MallocHooks::InitOnce();
   MallocHooks::ResetStats();
   EXPECT_EQ(0L, MallocHooks::allocation_count());
   EXPECT_EQ(0L, MallocHooks::heap_allocated_memory_in_bytes());
   const intptr_t buffer_size = 10;
   char* buffer = new char[buffer_size];
   MallocHookTestBufferInitializer(buffer, buffer_size);
 
   EXPECT_EQ(1L, MallocHooks::allocation_count());
   EXPECT_EQ(static_cast<intptr_t>(sizeof(char) * buffer_size),
             MallocHooks::heap_allocated_memory_in_bytes());
 
   delete[] buffer;
   EXPECT_EQ(0L, MallocHooks::allocation_count());
   EXPECT_EQ(0L, MallocHooks::heap_allocated_memory_in_bytes());
   MallocHooks::TearDown();
 
   FLAG_profiler_native_memory = enable_malloc_hooks_saved;
 }
 
 
 UNIT_TEST_CASE(FreeUnseenMemoryMallocHookTest) {
   bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
   FLAG_profiler_native_memory = true;
+  Profiler::InitAllocationSampleBuffer();
 
   MallocHooks::InitOnce();
   const intptr_t pre_hook_buffer_size = 3;
   char* pre_hook_buffer = new char[pre_hook_buffer_size];
   MallocHookTestBufferInitializer(pre_hook_buffer, pre_hook_buffer_size);
 
   MallocHooks::ResetStats();
   EXPECT_EQ(0L, MallocHooks::allocation_count());
   EXPECT_EQ(0L, MallocHooks::heap_allocated_memory_in_bytes());
 
@@ skipping 16 matching lines @@
   EXPECT_EQ(0L, MallocHooks::heap_allocated_memory_in_bytes());
   MallocHooks::TearDown();
 
   FLAG_profiler_native_memory = enable_malloc_hooks_saved;
 }
 
 
 VM_UNIT_TEST_CASE(StackTraceMallocHookSimpleTest) {
   bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
   FLAG_profiler_native_memory = true;
+  Profiler::InitAllocationSampleBuffer();
 
   MallocHooks::InitOnce();
   MallocHooks::ResetStats();
 
   bool enable_stack_traces_saved =
       MallocHooks::stack_trace_collection_enabled();
   MallocHooks::set_stack_trace_collection_enabled(true);
 
   char* var = static_cast<char*>(malloc(16 * sizeof(char)));
   Sample* sample = MallocHooks::GetSample(var);
@@ skipping 11 matching lines @@
 static char* DART_NOINLINE StackTraceLengthHelper(uintptr_t* end_address) {
   char* var = static_cast<char*>(malloc(16 * sizeof(char)));
   *end_address = OS::GetProgramCounter();
   return var;
 }
 
 
 VM_UNIT_TEST_CASE(StackTraceMallocHookLengthTest) {
   bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
   FLAG_profiler_native_memory = true;
+  Profiler::InitAllocationSampleBuffer();
 
   uintptr_t test_start_address =
       reinterpret_cast<uintptr_t>(Dart_TestStackTraceMallocHookLengthTest);
   uintptr_t helper_start_address =
       reinterpret_cast<uintptr_t>(StackTraceLengthHelper);
   uintptr_t helper_end_address = 0;
 
   MallocHooks::InitOnce();
   MallocHooks::ResetStats();
 
@@ skipping 34 matching lines @@
   free(var);
   MallocHooks::TearDown();
   MallocHooks::set_stack_trace_collection_enabled(enable_stack_traces_saved);
   FLAG_profiler_native_memory = enable_malloc_hooks_saved;
 }
 
 
 ISOLATE_UNIT_TEST_CASE(StackTraceMallocHookSimpleJSONTest) {
   bool enable_malloc_hooks_saved = FLAG_profiler_native_memory;
   FLAG_profiler_native_memory = true;
+  Profiler::InitAllocationSampleBuffer();
 
   MallocHooks::InitOnce();
   MallocHooks::ResetStats();
 
   bool enable_stack_traces_saved =
       MallocHooks::stack_trace_collection_enabled();
   MallocHooks::set_stack_trace_collection_enabled(true);
 
   ClearProfileVisitor cpv(Isolate::Current());
   Profiler::sample_buffer()->VisitSamples(&cpv);
@@ skipping 15 matching lines @@
 
   free(var);
   MallocHooks::TearDown();
   MallocHooks::set_stack_trace_collection_enabled(enable_stack_traces_saved);
   FLAG_profiler_native_memory = enable_malloc_hooks_saved;
 }
 
 };  // namespace dart
 
 #endif  // defined(DART_USE_TCMALLOC) && !defined(PRODUCT)