Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(364)

Issue 2966573003: Set UA override flag for Renderer-initiated NavigationRequest (Closed)

Created:
3 years, 5 months ago by jam
Modified:
3 years, 5 months ago
Reviewers:
CC:
chromium-reviews
Target Ref:
refs/branch-heads/3112
Project:
chromium
Visibility:
Public.

Description

Set UA override flag for Renderer-initiated NavigationRequest Use last committed NavigationEntry instead of the pending endtry (which can be null) to have the user agent override flag stick across navigations. The entry can affect navigation entry id but it is safe to replace it since the id used for browser-initiated navigation only. BUG=734772 Cq-Include-Trybots: master.tryserver.chromium.linux:linux_site_isolation Change-Id: Icb34f55af82bafde5a3c0e1457fa25c1172db9d0 Reviewed-on: https://chromium-review.googlesource.com/541277 Commit-Queue: Jinsuk Kim <jinsukkim@chromium.org>; Reviewed-by: Camille Lamy <clamy@chromium.org>; Cr-Original-Commit-Position: refs/heads/master@{#482311} Review-Url: https://codereview.chromium.org/2966573003 . Cr-Commit-Position: refs/branch-heads/3112@{#496} Cr-Branched-From: b6460e24cf59f429d69de255538d0fc7a425ccf9-refs/heads/master@{#474897} Committed: https://chromium.googlesource.com/chromium/src/+/790356ce6c03c372d5fe2310f4e319265441f231

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+16 lines, -12 lines) Patch
M content/browser/frame_host/navigation_request.h View 1 chunk +2 lines, -1 line 0 comments Download
M content/browser/frame_host/navigation_request.cc View 3 chunks +10 lines, -10 lines 0 comments Download
M content/browser/frame_host/navigator_impl.cc View 1 chunk +4 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
jam
3 years, 5 months ago (2017-06-29 23:18:09 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
790356ce6c03c372d5fe2310f4e319265441f231.

Powered by Google App Engine
This is Rietveld 408576698