Fix QuicNetworkTransaction*Tests to set QuicAlternativeService with

Fix QuicNetworkTransaction*Tests to set QuicAlternativeService with
current supported versions in the test suite.

Currently we ignore QUIC versions when GetAlternativeService. However,
in order to use the AlternativeService properly, a correct list of
versions in AlternativeServiceInfo should be set to HttpServerProperties
which contains the QUIC version that the running test is supporting.

This is in preparation to fix the tests that would blow up once we take
QUIC versions into account when selecting AlternativeService.

BUG=689762
Review-Url: https://codereview.chromium.org/2966563003
Cr-Commit-Position: refs/heads/master@{#483575}
Committed: https://chromium.googlesource.com/chromium/src/+/86838d5ee0c79c95644607bc0c29a7dcc54482b3

[Zhongyi Shi, 2017-06-29 19:56:41]

zhongyi@chromium.org changed reviewers:
+ rch@chromium.org

[Zhongyi Shi, 2017-06-29 20:09:01]

The CQ bit was checked by zhongyi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 20:09:30]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 20:57:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 20:57:03]

Dry run: This issue passed the CQ dry run.

[Ryan Hamilton, 2017-06-29 22:50:10]

lgtm

https://codereview.chromium.org/2966563003/diff/1/net/quic/chromium/quic_netw...
File net/quic/chromium/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2966563003/diff/1/net/quic/chromium/quic_netw...
net/quic/chromium/quic_network_transaction_unittest.cc:1474: }
You might consider doing something which avoids hard-coding v40 and v37.

for (QuicVersion version : kQuicSupportedVersions) {
 if (version == supported_versions.front())
  continue;
 supported_versions.push_back(version);
 break;
}

https://codereview.chromium.org/2966563003/diff/1/net/quic/chromium/quic_netw...
net/quic/chromium/quic_network_transaction_unittest.cc:4738: // Empty the
_current queue.
typo?

[Zhongyi Shi, 2017-06-29 23:54:51]

Patchset #2 (id:20001) has been deleted

[Zhongyi Shi, 2017-06-29 23:56:29]

Thanks for the review, landing now.

https://codereview.chromium.org/2966563003/diff/1/net/quic/chromium/quic_netw...
File net/quic/chromium/quic_network_transaction_unittest.cc (right):

https://codereview.chromium.org/2966563003/diff/1/net/quic/chromium/quic_netw...
net/quic/chromium/quic_network_transaction_unittest.cc:1474: }
On 2017/06/29 22:50:10, Ryan Hamilton wrote:
> You might consider doing something which avoids hard-coding v40 and v37.
> 
> for (QuicVersion version : kQuicSupportedVersions) {
>  if (version == supported_versions.front())
>   continue;
>  supported_versions.push_back(version);
>  break;
> }

Good point! Thanks for the suggestion!

https://codereview.chromium.org/2966563003/diff/1/net/quic/chromium/quic_netw...
net/quic/chromium/quic_network_transaction_unittest.cc:4738: // Empty the
_current queue.
On 2017/06/29 22:50:10, Ryan Hamilton wrote:
> typo?

whoops, fixed.

[Zhongyi Shi, 2017-06-29 23:56:43]

The CQ bit was checked by zhongyi@chromium.org

[Zhongyi Shi, 2017-06-29 23:56:43]

The patchset sent to the CQ was uploaded after l-g-t-m from rch@chromium.org
Link to the patchset: https://codereview.chromium.org/2966563003/#ps40001
(title: "Re #7")

[commit-bot: I haz the power, 2017-06-29 23:57:00]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 01:19:46]

CQ is committing da patch.

Bot data: {"patchset_id": 40001, "attempt_start_ts": 1498780603324350,
"parent_rev": "0a9d03ce07a9bec7a397bbb08c2bec0fe0e91d66", "commit_rev":
"86838d5ee0c79c95644607bc0c29a7dcc54482b3"}

[commit-bot: I haz the power, 2017-06-30 01:20:01]

Description was changed from

==========
Fix QuicNetworkTransaction*Tests to set QuicAlternativeService with
current supported versions in the test suite.

Currently we ignore QUIC versions when GetAlternativeService. However,
in order to use the AlternativeService properly, a correct list of
versions in AlternativeServiceInfo should be set to HttpServerProperties
which contains the QUIC version that the running test is supporting.

This is in preparation to fix the tests that would blow up once we take
QUIC versions into account when selecting AlternativeService.

BUG=689762
==========

to

==========
Fix QuicNetworkTransaction*Tests to set QuicAlternativeService with
current supported versions in the test suite.

Currently we ignore QUIC versions when GetAlternativeService. However,
in order to use the AlternativeService properly, a correct list of
versions in AlternativeServiceInfo should be set to HttpServerProperties
which contains the QUIC version that the running test is supporting.

This is in preparation to fix the tests that would blow up once we take
QUIC versions into account when selecting AlternativeService.

BUG=689762

Review-Url: https://codereview.chromium.org/2966563003
Cr-Commit-Position: refs/heads/master@{#483575}
Committed:
https://chromium.googlesource.com/chromium/src/+/86838d5ee0c79c95644607bc0c29...
==========

[commit-bot: I haz the power, 2017-06-30 01:20:02]

Committed patchset #2 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/86838d5ee0c79c95644607bc0c29...