third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl - Issue 2966523002: Blink-layer update to match WebAuthN spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl

Issue 2966523002: Blink-layer update to match WebAuthN spec (Closed)

Patch Set: Modify browser-side impl and unittests. Address mkwst comments. Created 3 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/modules/webauth/PublicKeyCredentialParameters.idl ('K') | « third_party/WebKit/Source/modules/webauth/PublicKeyCredentialParameters.idl ('k') | third_party/WebKit/Source/modules/webauth/PublicKeyCredentialUserEntity.idl » ('j') | third_party/WebKit/Source/modules/webauth/WebAuthentication.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl

diff --git a/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl b/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl

new file mode 100644

index 0000000000000000000000000000000000000000..27c59fd7cec99aa0575ccfdc756454c6ca8562e7

--- /dev/null

+++ b/third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl

@@ -0,0 +1,12 @@

+// Use of this source code is governed by a BSD-style license that can be

+// found in the LICENSE file.

+// https://w3c.github.io/webauthn/#dictdef-publickeycredentialrequestoptions

+dictionary PublicKeyCredentialRequestOptions {

+ required BufferSource challenge;

+ unsigned long timeout;

+ USVString rpId;

+ sequence <PublicKeyCredentialDescriptor> allowList;

engedy 2017/07/05 18:51:06 Do we need the default value here, i.e. `allowCred

engedy 2017/07/05 18:51:06 s/allowList/allowCredentials/

kpaulhamus 2017/07/12 21:21:47 Done.

+};

engedy 2017/07/05 18:51:06 nit: Add TODO(crbug.com/...) for |extensions| fiel

kpaulhamus 2017/07/12 21:21:47 Done.