third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl - Issue 2966523002: Blink-layer update to match WebAuthN spec

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/webauth/PublicKeyCredentialRequestOptions.idl

Issue 2966523002: Blink-layer update to match WebAuthN spec (Closed)

Patch Set: Modify browser-side impl and unittests. Address mkwst comments. Created 3 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2016 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 // https://w3c.github.io/webauthn/#dictdef-publickeycredentialrequestoptions

	6

	7 dictionary PublicKeyCredentialRequestOptions {

	8 required BufferSource challenge;

	9 unsigned long timeout;

	10 USVString rpId;

	11 sequence <PublicKeyCredentialDescriptor> allowList;
	engedy 2017/07/05 18:51:06 Do we need the default value here, i.e. `allowCred Do we need the default value here, i.e. `allowCredentials = []`? engedy 2017/07/05 18:51:06 s/allowList/allowCredentials/ s/allowList/allowCredentials/ kpaulhamus 2017/07/12 21:21:47 Done. Show quoted text On 2017/07/05 18:51:06, engedy wrote: > s/allowList/allowCredentials/ Done. kpaulhamus 2017/07/12 21:21:47 Done. Show quoted text On 2017/07/05 18:51:06, engedy wrote: > Do we need the default value here, i.e. `allowCredentials = []`? Done.
	12 };
	engedy 2017/07/05 18:51:06 nit: Add TODO(crbug.com/...) for \|extensions\| fiel nit: Add TODO(crbug.com/...) for \|extensions\| field? kpaulhamus 2017/07/12 21:21:47 Done. Show quoted text On 2017/07/05 18:51:06, engedy wrote: > nit: Add TODO(crbug.com/...) for \|extensions\| field? Done.
OLD	NEW