Convert editing/selection/shift-click.html to use assert_selection()

Convert editing/selection/shift-click.html to use assert_selection()

This patch changes "editing/selection/shift-click.html" to use
|assert_selection()| for improving readability.


BUG=679977
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2966473002
Cr-Commit-Position: refs/heads/master@{#483959}
Committed: https://chromium.googlesource.com/chromium/src/+/7fe0cb0db51df722d3ff5b657ab430fda54108e3

[yosin_UTC9, 2017-06-29 06:17:45]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 06:17:58]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-29 06:23:52]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 06:24:00]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-29 06:24:24]

Patchset #1 (id:1) has been deleted

[commit-bot: I haz the power, 2017-06-29 06:26:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 06:26:10]

Dry run: Try jobs failed on following builders:
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2017-06-29 07:32:58]

Description was changed from

==========
2017-06-29T15:16:06

BUG=679977

2017-06-29T15:16:01
==========

to

==========
Convert editing/selection/shift-click.html to use assert_selection()

This patch changes "editing/selection/shift-click.html" to use
|assert_selection()| for improving readability.


BUG=679977
TEST=n/a; no behavior changes
==========

[yosin_UTC9, 2017-06-29 08:17:46]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 08:17:52]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-29 08:18:01]

Patchset #1 (id:20001) has been deleted

[commit-bot: I haz the power, 2017-06-29 08:20:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 08:20:07]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[yosin_UTC9, 2017-06-29 08:41:57]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 08:42:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-29 08:44:22]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 08:44:24]

Dry run: Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)
  ios-simulator-xcode-clang on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator-xco...)
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[yosin_UTC9, 2017-06-29 08:46:03]

Patchset #2 (id:60001) has been deleted

[yosin_UTC9, 2017-06-29 08:46:09]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-29 08:46:27]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-06-29 09:46:07]

yosin@chromium.org changed reviewers:
+ xiaochengh@chromium.org, yoichio@chromium.org

[yosin_UTC9, 2017-06-29 09:46:08]

PTAL

[commit-bot: I haz the power, 2017-06-29 10:06:29]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-29 10:06:30]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-06-30 01:55:56]

https://codereview.chromium.org/2966473002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/selection/shift-click.html (right):

https://codereview.chromium.org/2966473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/shift-click.html:88: // These
two fail on Mac due to https://wkb.ug/36256.
This link doesn't work could you use original one?

[yosin_UTC9, 2017-06-30 08:30:03]

PTAL

Updated.

https://codereview.chromium.org/2966473002/diff/80001/third_party/WebKit/Layo...
File third_party/WebKit/LayoutTests/editing/selection/shift-click.html (right):

https://codereview.chromium.org/2966473002/diff/80001/third_party/WebKit/Layo...
third_party/WebKit/LayoutTests/editing/selection/shift-click.html:88: // These
two fail on Mac due to https://wkb.ug/36256.
On 2017/06/30 at 01:55:56, yoichio wrote:
> This link doesn't work could you use original one?

Done.

It could be http://wkb.ug/36256, which use "http" instead of "https".

[yosin_UTC9, 2017-06-30 08:30:07]

The CQ bit was checked by yosin@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 08:30:13]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-06-30 10:09:38]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 10:09:39]

Dry run: This issue passed the CQ dry run.

[yoichio, 2017-07-03 01:48:03]

lgtm

[yosin_UTC9, 2017-07-03 01:58:21]

The CQ bit was checked by yosin@chromium.org

[commit-bot: I haz the power, 2017-07-03 01:58:28]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 01:58:29]

This CL has an open dependency (Issue 2963113002 Patch 100001). Please resolve
the dependency and try again.
If you are sure that there is no real dependency, please use one of the options
listed in https://goo.gl/9Es4OR to land the CL.

[yosin_UTC9, 2017-07-03 06:12:44]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-07-03 06:12:44]

The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2966473002/#ps120001
(title: "2017-07-03T15:11:03 Rebase")

[commit-bot: I haz the power, 2017-07-03 06:12:57]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yosin_UTC9, 2017-07-03 06:17:47]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2017-07-03 06:31:40]

Patchset #4 (id:120001) has been deleted

[yosin_UTC9, 2017-07-03 06:31:59]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2017-07-03 06:32:00]

The patchset sent to the CQ was uploaded after l-g-t-m from yoichio@chromium.org
Link to the patchset: https://codereview.chromium.org/2966473002/#ps140001
(title: "2017-07-03T15:30:45 Rebase")

[commit-bot: I haz the power, 2017-07-03 06:32:04]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 08:01:25]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1499063519589510,
"parent_rev": "92a96f7633e53bb4a4d76651a4b5834c58f6a34b", "commit_rev":
"cc27b59b8d45b878f6adc16afe93dab49a62d188"}

[commit-bot: I haz the power, 2017-07-03 08:01:40]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1499063519589510,
"parent_rev": "ec49f96b9874e4e0006805872601ffdbd792fda7", "commit_rev":
"ca6ac942ab641fa48e38f1bd93c437fd817038db"}

[commit-bot: I haz the power, 2017-07-03 08:01:54]

CQ is committing da patch.

Bot data: {"patchset_id": 140001, "attempt_start_ts": 1499063519589510,
"parent_rev": "e02fa0b939f8ed4e7518376d7eff4e10ddf040b1", "commit_rev":
"7fe0cb0db51df722d3ff5b657ab430fda54108e3"}

[commit-bot: I haz the power, 2017-07-03 08:02:11]

Description was changed from

==========
Convert editing/selection/shift-click.html to use assert_selection()

This patch changes "editing/selection/shift-click.html" to use
|assert_selection()| for improving readability.


BUG=679977
TEST=n/a; no behavior changes
==========

to

==========
Convert editing/selection/shift-click.html to use assert_selection()

This patch changes "editing/selection/shift-click.html" to use
|assert_selection()| for improving readability.


BUG=679977
TEST=n/a; no behavior changes

Review-Url: https://codereview.chromium.org/2966473002
Cr-Commit-Position: refs/heads/master@{#483959}
Committed:
https://chromium.googlesource.com/chromium/src/+/7fe0cb0db51df722d3ff5b657ab4...
==========

[commit-bot: I haz the power, 2017-07-03 08:02:12]

Committed patchset #4 (id:140001) as
https://chromium.googlesource.com/chromium/src/+/7fe0cb0db51df722d3ff5b657ab4...