Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1522)

Unified Diff: chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc

Issue 2966453002: Chrome Cleaner UI: Add logs upload permission checkbox to the dialog (Closed)
Patch Set: Rebase Created 3 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
diff --git a/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc b/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
index 46f4b8c30a5c4ce1326a04498c6a811aa399cd0f..bd5ec580485c3fa8c0a0fe7aeb4a6205a5a53ea6 100644
--- a/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
+++ b/chrome/browser/ui/webui/settings/chrome_cleanup_handler.cc
@@ -4,6 +4,8 @@
#include "chrome/browser/ui/webui/settings/chrome_cleanup_handler.h"
+#include <string>
+
#include "base/command_line.h"
#include "base/feature_list.h"
#include "base/synchronization/lock.h"
@@ -146,7 +148,7 @@ void ChromeCleanupHandler::HandleStartCleanup(const base::ListValue* args) {
DCHECK_EQ(0U, args->GetSize());
controller_->ReplyWithUserResponse(
- profile_, ChromeCleanerController::UserResponse::kAccepted);
+ profile_, ChromeCleanerController::UserResponse::kAcceptedWithoutLogs);
robertshield 2017/06/29 13:47:21 Shouldn't this take the value of the toggle in the
robertshield 2017/06/29 13:56:28 Nm, just saw your comment in the mail. Maybe a TOD
proberge 2017/06/29 13:56:29 Yes. @alito please add a TODO under my name above
alito 2017/06/29 17:14:27 Added a TODO assigned to proberge@.
alito 2017/06/29 17:14:27 Done.
}
} // namespace settings

Powered by Google App Engine
This is Rietveld 408576698