Chrome Cleaner UI: Add logs upload permission checkbox to the dialog

chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h

Index: chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h
diff --git a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h
index 64b1ea812b56b16be017339fc883bb17765256ad..8c87c4f13cb6e5de3ad19c4f64eda31318204fc3 100644
--- a/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h
+++ b/chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h
@@ -27,10 +27,12 @@ class ChromeCleanerDialogControllerImpl
 
   // ChromeCleanerDialogController overrides.
   void DialogShown() override;
-  void Accept() override;
+  void Accept(bool logs_enabled) override;
   void Cancel() override;
   void Close() override;
-  void DetailsButtonClicked() override;
+  void DetailsButtonClicked(bool logs_enabled) override;
+  void SetLogsEnabled(bool logs_enabled) override;

[proberge, 2017/06/29 13:55:53]

What's the advantage of having both SetLogsEnabled and extra paramters to
Accept/DetailsButtonClicked ?

If SetLogsEnabled is called every time the checkbox state changes, wouldn't the
Accept/DetailsButtonClicked always have the same logs_enabled value as the last
SetLogsEnabled?

[alito, 2017/06/29 17:14:27]

The global state can change from the webui page without being reflected in the
modal dialog. This ensures that when the user clicks a button on the modal
dialog, the actual state of the checkbox at that time is propagated to the
controller atomically.

+  bool LogsEnabled() override;
 
   // ChromeCleanerController::Observer overrides.
   void OnIdle(ChromeCleanerController::IdleReason idle_reason) override;