Chrome Cleaner UI: Add logs upload permission checkbox to the dialog

chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_impl_win.h

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SAFE_BROWSING_CHROME_CLEANER_CHROME_CLEANER_DIALOG_CONTROLLER_IMPL_WIN_H_
 #define CHROME_BROWSER_SAFE_BROWSING_CHROME_CLEANER_CHROME_CLEANER_DIALOG_CONTROLLER_IMPL_WIN_H_
 
 #include <set>
 
 #include "base/files/file_path.h"
 #include "base/macros.h"
 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_controller_win.h"
 #include "chrome/browser/safe_browsing/chrome_cleaner/chrome_cleaner_dialog_controller_win.h"
 
 class Browser;
 
 namespace safe_browsing {
 
 class ChromeCleanerDialogControllerImpl
     : public ChromeCleanerDialogController,
       public ChromeCleanerController::Observer {
  public:
   // An instance should only be created when |cleaner_controller| is in the
   // kScanning state.
   explicit ChromeCleanerDialogControllerImpl(
       ChromeCleanerController* cleaner_controller);
 
   // ChromeCleanerDialogController overrides.
   void DialogShown() override;
-  void Accept() override;
+  void Accept(bool logs_enabled) override;
   void Cancel() override;
   void Close() override;
-  void DetailsButtonClicked() override;
+  void DetailsButtonClicked(bool logs_enabled) override;
+  void SetLogsEnabled(bool logs_enabled) override;

[proberge, 2017/06/29 13:55:53]

What's the advantage of having both SetLogsEnabled and extra paramters to
Accept/DetailsButtonClicked ?

If SetLogsEnabled is called every time the checkbox state changes, wouldn't the
Accept/DetailsButtonClicked always have the same logs_enabled value as the last
SetLogsEnabled?

[alito, 2017/06/29 17:14:27]

The global state can change from the webui page without being reflected in the
modal dialog. This ensures that when the user clicks a button on the modal
dialog, the actual state of the checkbox at that time is propagated to the
controller atomically.

+  bool LogsEnabled() override;
 
   // ChromeCleanerController::Observer overrides.
   void OnIdle(ChromeCleanerController::IdleReason idle_reason) override;
   void OnScanning() override;
   void OnInfected(const std::set<base::FilePath>& files_to_delete) override;
   void OnCleaning(const std::set<base::FilePath>& files_to_delete) override;
   void OnRebootRequired() override;
 
  protected:
   ~ChromeCleanerDialogControllerImpl() override;
 
  private:
   void OnInteractionDone();
 
   ChromeCleanerController* cleaner_controller_ = nullptr;
   bool dialog_shown_ = false;
   Browser* browser_ = nullptr;
 
   DISALLOW_COPY_AND_ASSIGN(ChromeCleanerDialogControllerImpl);
 };
 
 }  // namespace safe_browsing
 
 #endif  // CHROME_BROWSER_SAFE_BROWSING_CHROME_CLEANER_CHROME_CLEANER_DIALOG_CONTROLLER_IMPL_WIN_H_