Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(176)

Issue 2966433002: Get rid of VisibleSelectionTemplate::has_trailing_whitespace_ (Closed)

Created:
3 years, 5 months ago by yosin_UTC9
Modified:
3 years, 5 months ago
Reviewers:
yoichio
CC:
blink-reviews, chromium-reviews
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Get rid of VisibleSelectionTemplate::has_trailing_whitespace_ This patch gets rid of |has_trailing_whitespace_| member variable from |VisibleSelectionTemplate| class since after the patch[1], this variable doesn't do nothing for improving code health. [1] http://crrev.com/2951353003 Get rid of *live granularity* behavior from selection BUG=692923 TEST=n/a; no behavior changes Review-Url: https://codereview.chromium.org/2966433002 Cr-Commit-Position: refs/heads/master@{#484177} Committed: https://chromium.googlesource.com/chromium/src/+/09dcc24b3adaa3fa2db4cbef0a8e2d4bcf0f1724

Patch Set 1 : 2017-06-29T10:42:51 #

Patch Set 2 : 2017-07-04T18:31:35 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -20 lines) Patch
M third_party/WebKit/Source/core/editing/VisibleSelection.h View 1 1 chunk +0 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/editing/VisibleSelection.cpp View 1 8 chunks +3 lines, -15 lines 1 comment Download

Messages

Total messages: 17 (13 generated)
yosin_UTC9
PTAL
3 years, 5 months ago (2017-07-04 09:32:25 UTC) #9
yoichio
https://codereview.chromium.org/2966433002/diff/20001/third_party/WebKit/Source/core/editing/VisibleSelection.cpp File third_party/WebKit/Source/core/editing/VisibleSelection.cpp (left): https://codereview.chromium.org/2966433002/diff/20001/third_party/WebKit/Source/core/editing/VisibleSelection.cpp#oldcode194 third_party/WebKit/Source/core/editing/VisibleSelection.cpp:194: result.has_trailing_whitespace_ = true; |has_trailing_whitespace_| would not be |true| unless ...
3 years, 5 months ago (2017-07-05 01:42:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966433002/20001
3 years, 5 months ago (2017-07-05 01:53:39 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-05 01:58:19 UTC) #17
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/09dcc24b3adaa3fa2db4cbef0a8e...

Powered by Google App Engine
This is Rietveld 408576698