Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(104)

Issue 2966383004: Adjust view for the password exceptions in the new UI (Closed)

Created:
3 years, 5 months ago by melandory
Modified:
3 years, 5 months ago
Reviewers:
Theresa
CC:
chromium-reviews, gcasto+watchlist_chromium.org, vabr+watchlistpasswordmanager_chromium.org, agrieve+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Adjust view for the password exceptions in the new UI BUG=619868 Review-Url: https://codereview.chromium.org/2966383004 Cr-Commit-Position: refs/heads/master@{#485289} Committed: https://chromium.googlesource.com/chromium/src/+/6383dae82efae518c8bea41fae9a0fcec6ff461e

Patch Set 1 #

Patch Set 2 : . #

Total comments: 4

Patch Set 3 : adressed comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+101 lines, -56 lines) Patch
M chrome/android/java/res/layout/password_entry_editor_interactive.xml View 1 1 chunk +1 line, -42 lines 0 comments Download
A chrome/android/java/res/layout/password_entry_editor_site_row.xml View 1 2 1 chunk +55 lines, -0 lines 0 comments Download
A chrome/android/java/res/layout/password_entry_exception.xml View 1 2 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/password/PasswordEntryEditor.java View 3 chunks +24 lines, -14 lines 0 comments Download

Messages

Total messages: 22 (17 generated)
melandory
PTAL, thanks. (Screenshots are attached to the bug)
3 years, 5 months ago (2017-07-10 10:52:19 UTC) #10
Theresa
lgtm % style nits https://codereview.chromium.org/2966383004/diff/20001/chrome/android/java/res/layout/password_entry_editor_site_row.xml File chrome/android/java/res/layout/password_entry_editor_site_row.xml (right): https://codereview.chromium.org/2966383004/diff/20001/chrome/android/java/res/layout/password_entry_editor_site_row.xml#newcode21 chrome/android/java/res/layout/password_entry_editor_site_row.xml:21: android:textAppearance="?android:attr/textAppearanceMedium" /> nit: add a ...
3 years, 5 months ago (2017-07-10 15:12:51 UTC) #11
melandory
https://codereview.chromium.org/2966383004/diff/20001/chrome/android/java/res/layout/password_entry_editor_site_row.xml File chrome/android/java/res/layout/password_entry_editor_site_row.xml (right): https://codereview.chromium.org/2966383004/diff/20001/chrome/android/java/res/layout/password_entry_editor_site_row.xml#newcode21 chrome/android/java/res/layout/password_entry_editor_site_row.xml:21: android:textAppearance="?android:attr/textAppearanceMedium" /> On 2017/07/10 15:12:50, Theresa wrote: > nit: ...
3 years, 5 months ago (2017-07-10 16:19:37 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966383004/40001
3 years, 5 months ago (2017-07-10 16:19:55 UTC) #19
commit-bot: I haz the power
3 years, 5 months ago (2017-07-10 16:23:49 UTC) #22
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://chromium.googlesource.com/chromium/src/+/6383dae82efae518c8bea41fae9a...

Powered by Google App Engine
This is Rietveld 408576698