Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2966293002: android: Fix input list for jni_registration_generator.py (Closed)

Created:
3 years, 5 months ago by agrieve
Modified:
3 years, 5 months ago
Reviewers:
jbudorick, yipengw
CC:
chromium-reviews, danakj+watch_chromium.org, vmpstr+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

android: Fix input list for jni_registration_generator.py Not including the full input list is causing the target to not re-run when it should. BUG=683256 Review-Url: https://codereview.chromium.org/2966293002 Cr-Commit-Position: refs/heads/master@{#484408} Committed: https://chromium.googlesource.com/chromium/src/+/5b20daae4209bc1f27f6d85cd042d3fd1c3efec6

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -7 lines) Patch
M base/android/jni_generator/jni_registration_generator.py View 1 chunk +8 lines, -7 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
yipengw
lgtm LGTM
3 years, 5 months ago (2017-07-05 20:39:24 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966293002/1
3 years, 5 months ago (2017-07-05 20:44:53 UTC) #8
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. CQ run can only be started once the ...
3 years, 5 months ago (2017-07-05 20:44:54 UTC) #10
jbudorick
lgtm
3 years, 5 months ago (2017-07-05 23:48:19 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966293002/1
3 years, 5 months ago (2017-07-05 23:49:12 UTC) #14
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 00:23:26 UTC) #17
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5b20daae4209bc1f27f6d85cd042...

Powered by Google App Engine
This is Rietveld 408576698