Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(255)

Issue 296623002: Integrate perfvis profiling mode, and temporary report generator. (Closed)

Created:
6 years, 7 months ago by vmiura
Modified:
5 years, 10 months ago
Reviewers:
Sami
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Integrate perfvis profiling mode, and temporary report generator. BUG=

Patch Set 1 #

Patch Set 2 : Skip 1st and last frames in perfvis report. Group stack entry points by module. #

Patch Set 3 : Size table for MBP screen. #

Patch Set 4 : Make perfhost executable after download from cloud storage. #

Patch Set 5 : Remove perfhost dependencies on libuma & libunwind .so files. #

Patch Set 6 : Improve symbol matching on L. #

Patch Set 7 : Move all stack pre-processing to perf_to_json_script, making perf_vis just a dumb standalone UI for… #

Total comments: 2

Patch Set 8 : Some fixes. Match timestamps to tracing scale. #

Patch Set 9 : Rebase #

Patch Set 10 : Clear some white space errors. #

Patch Set 11 : Rebase #

Patch Set 12 : Rebase #

Patch Set 13 : Filtered View mode for multiple selections. #

Patch Set 14 : Support content_shell. #

Patch Set 15 : Rebase #

Patch Set 16 : #

Patch Set 17 : Stack hiding function. #

Patch Set 18 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2192 lines, -52 lines) Patch
M tools/profile_chrome/third_party/perf_to_tracing.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 1 chunk +1 line, -1 line 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/__init__.py View 1 2 3 4 5 6 7 8 9 10 11 1 chunk +4 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiler/perf_profiler.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/profiler/perf_vis/__init__.py View 11 0 chunks +-1 lines, --1 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/d3.v3.min.js View 11 1 chunk +5 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/jquery-1.11.0.min.js View 11 1 chunk +4 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/jquery.dataTables.css View 11 1 chunk +399 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/jquery.dataTables.min.js View 11 1 chunk +152 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/perf-vis.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +814 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/perf-vis-template.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +143 lines, -0 lines 0 comments Download
A + tools/telemetry/telemetry/core/platform/profiler/perf_vis/perf_to_tracing.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 5 chunks +50 lines, -52 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/perf_vis.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 1 chunk +264 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perf_vis/sammy-latest.min.js View 11 1 chunk +5 lines, -0 lines 0 comments Download
A tools/telemetry/telemetry/core/platform/profiler/perfvis_profiler.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +315 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/core/platform/profiling_controller_backend.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/page/page_runner.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 1 chunk +2 lines, -0 lines 0 comments Download
M tools/telemetry/telemetry/timeline/model.py View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 3 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 8 (0 generated)
Sami
https://codereview.chromium.org/296623002/diff/120001/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py (right): https://codereview.chromium.org/296623002/diff/120001/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py#newcode218 tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:218: # to lose connection. Protip: this happens if you ...
6 years, 7 months ago (2014-05-22 22:25:11 UTC) #1
vmiura
https://codereview.chromium.org/296623002/diff/120001/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py File tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py (right): https://codereview.chromium.org/296623002/diff/120001/tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py#newcode218 tools/telemetry/telemetry/core/backends/chrome/android_browser_finder.py:218: # to lose connection. On 2014/05/22 22:25:11, Sami wrote: ...
6 years, 7 months ago (2014-05-23 00:49:35 UTC) #2
Sami
Hey Victor, do you mind if I pull some things out of this patch that ...
6 years, 6 months ago (2014-06-03 18:46:19 UTC) #3
vmiura
On 2014/06/03 18:46:19, Sami wrote: > Hey Victor, do you mind if I pull some ...
6 years, 6 months ago (2014-06-03 20:36:49 UTC) #4
Sami
On 2014/06/03 20:36:49, vmiura wrote: > On 2014/06/03 18:46:19, Sami wrote: > > Hey Victor, ...
6 years, 6 months ago (2014-06-05 11:03:14 UTC) #5
vmiura
Rebased to ToT. Sami, adb_profile_chrome is OK save for nits I think.
6 years, 6 months ago (2014-06-25 12:09:50 UTC) #6
nduca
are we planning to land this? if so, why duplicate sunburst chart? we have a ...
6 years, 5 months ago (2014-07-16 18:19:21 UTC) #7
vmiura
6 years, 5 months ago (2014-07-16 19:42:35 UTC) #8
On 2014/07/16 18:19:21, nduca wrote:
> are we planning to land this? if so, why duplicate sunburst chart?
> 
> we have a tvcm version of sunburst, remember?

Nah, this is never going to be landed.  We just need to get the features on the
trace-viewer version up to par.

Powered by Google App Engine
This is Rietveld 408576698