tools/telemetry/telemetry/core/platform/profiling_controller_backend.py - Issue 296623002: Integrate perfvis profiling mode, and temporary report generator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/telemetry/telemetry/core/platform/profiling_controller_backend.py

Issue 296623002: Integrate perfvis profiling mode, and temporary report generator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « tools/telemetry/telemetry/core/platform/profiler/perfvis_profiler.py ('k') | tools/telemetry/telemetry/page/page_runner.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: tools/telemetry/telemetry/core/platform/profiling_controller_backend.py

diff --git a/tools/telemetry/telemetry/core/platform/profiling_controller_backend.py b/tools/telemetry/telemetry/core/platform/profiling_controller_backend.py

index 1775fc015f12d540c3dd54a09853e1abfaeed0c0..af8c24095456401aa7c0163a7a929097ed28c1fb 100644

--- a/tools/telemetry/telemetry/core/platform/profiling_controller_backend.py

+++ b/tools/telemetry/telemetry/core/platform/profiling_controller_backend.py

@@ -42,6 +42,8 @@ class ProfilingControllerBackend(object):

Returns:

A list of filenames produced by the profiler.

"""

+ for profiler in self._active_profilers:

+ profiler.StopProfile()

output_files = []

for profiler in self._active_profilers:

output_files.extend(profiler.CollectProfile())