Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2966163006:
Android: Enable depfile for generate_jni_registration() template (Closed)
DescriptionAndroid: Enable depfile for generate_jni_registration() template
This is what I tried to fix in 5b20daae4209bc1f27f6d85cd042d3fd1c3efec6.
BUG=683256, 442418
Review-Url: https://codereview.chromium.org/2966163006
Cr-Commit-Position: refs/heads/master@{#484792}
Committed: https://chromium.googlesource.com/chromium/src/+/5c6ff259aa83531bd04baef812e6c3c0c501d6ac
Patch Set 1 #
Messages
Total messages: 21 (13 generated)
The CQ bit was checked by agrieve@chromium.org to run a CQ dry run
Description was changed from ========== Android: Enable depfile for generate_jni_registration() template This is what I tried to fix in 5b20daae4209bc1f27f6d85cd042d3fd1c3efec6. BUG=683256 ========== to ========== Android: Enable depfile for generate_jni_registration() template This is what I tried to fix in 5b20daae4209bc1f27f6d85cd042d3fd1c3efec6. BUG=683256 ==========
agrieve@chromium.org changed reviewers: + jbudorick@chromium.org
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
On 2017/07/06 20:36:28, agrieve wrote: > mailto:agrieve@chromium.org changed reviewers: > + mailto:jbudorick@chromium.org :/
ah. lgtm
The CQ bit was unchecked by agrieve@chromium.org
Description was changed from ========== Android: Enable depfile for generate_jni_registration() template This is what I tried to fix in 5b20daae4209bc1f27f6d85cd042d3fd1c3efec6. BUG=683256 ========== to ========== Android: Enable depfile for generate_jni_registration() template This is what I tried to fix in 5b20daae4209bc1f27f6d85cd042d3fd1c3efec6. BUG=683256,442418 ==========
The CQ bit was checked by agrieve@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by alexis.menard@intel.com
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: android_n5x_swarming_rel on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_n5x_...)
The CQ bit was checked by jbudorick@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 1, "attempt_start_ts": 1499385747105920, "parent_rev":
"7e5dc58f0e1c227524b2181232f01041a77603e3", "commit_rev":
"5c6ff259aa83531bd04baef812e6c3c0c501d6ac"}
Message was sent while issue was closed.
Description was changed from ========== Android: Enable depfile for generate_jni_registration() template This is what I tried to fix in 5b20daae4209bc1f27f6d85cd042d3fd1c3efec6. BUG=683256,442418 ========== to ========== Android: Enable depfile for generate_jni_registration() template This is what I tried to fix in 5b20daae4209bc1f27f6d85cd042d3fd1c3efec6. BUG=683256,442418 Review-Url: https://codereview.chromium.org/2966163006 Cr-Commit-Position: refs/heads/master@{#484792} Committed: https://chromium.googlesource.com/chromium/src/+/5c6ff259aa83531bd04baef812e6... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1) as https://chromium.googlesource.com/chromium/src/+/5c6ff259aa83531bd04baef812e6... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
