DescriptionRevert of Reuse FileTasks when entries are not changed. (patchset #3 id:40001 of https://codereview.chromium.org/2833413003/ )
Reason for revert:
We'd like to revert this patch because this seem to have caused regression crbug.com/738803.
2973003002 needs to be merged before this CL in order to revert another dependent change first.
Original issue's description:
> Reuse FileTasks when entries are not changed.
>
> fileManagerPrivate.getFileTasks is slow.
> However, every time a file is copied during multi file copy, the method
> was called via CHANGE_THROTTLED event listener.
> This CL stops creating FileTasks again when file entries for the
> previous FileTasks are same as the current ones.
> Other possible solution to this problem is to change C++ interface of
> fileManagerPrivate.getFileTasks to support incremental update of
> FileTasks.
>
> BUG=462989, 712121
> CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
>
> Review-Url: https://codereview.chromium.org/2833413003
> Cr-Commit-Position: refs/heads/master@{#467264}
> Committed: https://chromium.googlesource.com/chromium/src/+/6e537c987f4d8cc6fcfda8f80b4c3216663371d4
TBR=fukino@chromium.org,tetsui@google.com
# Not skipping CQ checks because original CL landed more than 1 days ago.
BUG=462989, 712121, 738803
Review-Url: https://codereview.chromium.org/2966163005
Cr-Commit-Position: refs/heads/master@{#484512}
Committed: https://chromium.googlesource.com/chromium/src/+/5474326ed3852a9e39a625af8c3b4f1b46ac7854
Patch Set 1 #
Messages
Total messages: 12 (7 generated)
|