Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1233)

Issue 2966163005: Revert of Reuse FileTasks when entries are not changed. (Closed)

Created:
3 years, 5 months ago by yamaguchi
Modified:
3 years, 5 months ago
Reviewers:
tetsui, fukino, tetsui2
CC:
chromium-reviews, oka+watch_chromium.org, rginda+watch_chromium.org, mtomasz+watch_chromium.org, yamaguchi+watch_chromium.org, fukino+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reuse FileTasks when entries are not changed. (patchset #3 id:40001 of https://codereview.chromium.org/2833413003/ ) Reason for revert: We'd like to revert this patch because this seem to have caused regression crbug.com/738803. 2973003002 needs to be merged before this CL in order to revert another dependent change first. Original issue's description: > Reuse FileTasks when entries are not changed. > > fileManagerPrivate.getFileTasks is slow. > However, every time a file is copied during multi file copy, the method > was called via CHANGE_THROTTLED event listener. > This CL stops creating FileTasks again when file entries for the > previous FileTasks are same as the current ones. > Other possible solution to this problem is to change C++ interface of > fileManagerPrivate.getFileTasks to support incremental update of > FileTasks. > > BUG=462989, 712121 > CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation > > Review-Url: https://codereview.chromium.org/2833413003 > Cr-Commit-Position: refs/heads/master@{#467264} > Committed: https://chromium.googlesource.com/chromium/src/+/6e537c987f4d8cc6fcfda8f80b4c3216663371d4 TBR=fukino@chromium.org,tetsui@google.com # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=462989, 712121, 738803 Review-Url: https://codereview.chromium.org/2966163005 Cr-Commit-Position: refs/heads/master@{#484512} Committed: https://chromium.googlesource.com/chromium/src/+/5474326ed3852a9e39a625af8c3b4f1b46ac7854

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -76 lines) Patch
M ui/file_manager/file_manager/common/js/util.js View 1 chunk +0 lines, -22 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/file_tasks.js View 1 chunk +0 lines, -9 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/task_controller.js View 3 chunks +23 lines, -45 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
yamaguchi
Created Revert of Reuse FileTasks when entries are not changed.
3 years, 5 months ago (2017-07-06 04:47:18 UTC) #1
tetsui
lgtm
3 years, 5 months ago (2017-07-06 07:57:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966163005/1
3 years, 5 months ago (2017-07-06 08:54:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2966163005/1
3 years, 5 months ago (2017-07-06 08:59:20 UTC) #9
commit-bot: I haz the power
3 years, 5 months ago (2017-07-06 09:24:34 UTC) #12
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/chromium/src/+/5474326ed3852a9e39a625af8c3b...

Powered by Google App Engine
This is Rietveld 408576698