Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2965973002:
Remove delay for the first JumpList top site sync in one session (Closed)
|
Created:
3 years, 5 months ago by chengx Modified:
3 years, 5 months ago Reviewers:
Patrick Monette CC:
chromium-reviews Target Ref:
refs/heads/master Project:
chromium Visibility:
Public. |
DescriptionRemove delay for the first JumpList top site sync in one session
In current JumpList implementation, when the first tab is closed in
one session, it doesn't trigger an update but a TopSites sync. This
sync will then trigger an update for both mostly visited and recently
closed categories. We don't need to delay this TopSites sync,
otherwise it will take at least 7 seconds to get the JumpList
refreshed after the first tab is closed in one session.
BUG=733034
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng
Review-Url: https://codereview.chromium.org/2965973002
Cr-Commit-Position: refs/heads/master@{#484446}
Committed: https://chromium.googlesource.com/chromium/src/+/93fc3e41c9acda3fe3b2abca635f995f18889d8f
Patch Set 1 #
Messages
Total messages: 31 (25 generated)
Description was changed from ========== Remove delay for the first top site sync BUG= ========== to ========== Remove delay for the first top site sync BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
Patchset #2 (id:20001) has been deleted
Patchset #1 (id:1) has been deleted
Description was changed from ========== Remove delay for the first top site sync BUG= CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Remove delay for the first top site sync BUG=733034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Description was changed from ========== Remove delay for the first top site sync BUG=733034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Remove delay for the first JumpList top site sync BUG=733034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
Description was changed from ========== Remove delay for the first JumpList top site sync BUG=733034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Remove delay for the first JumpList top site sync in one session In current JumpList implementation, when the first tab is closed in one session, it doesn't trigger an update but a TopSites sync. This sync will then trigger an update for both mostly visited and recently closed categories. We don't need to delay this TopSites sync, otherwise it will take at least 7 seconds to get the JumpList refreshed after the first tab is closed in one session. BUG=733034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ==========
Patchset #1 (id:40001) has been deleted
chengx@chromium.org changed reviewers: + pmonette@chromium.org
Hi Patrick, can you please help review this small CL? Greg (grt@) may be the only one who follows the current JumpList logic after I've rewritten almost the whole class. However, he won't be back to office for another 2 weeks. Specifically, there is a code move from line 404 to line 340. Other than that, the code change is pretty easy to follow. Thanks for the help in advance!
lgtm
The CQ bit was checked by chengx@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: ios-device on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?)) ios-device-xcode-clang on master.tryserver.chromium.mac (JOB_TIMED_OUT, build has not started yet; builder either lacks capacity or does not exist (misspelled?))
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chengx@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by chengx@chromium.org
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
CQ is committing da patch.
Bot data: {"patchset_id": 60001, "attempt_start_ts": 1499308944744740,
"parent_rev": "e7759504f2a5d6145db6d102c7fd15cf614def66", "commit_rev":
"93fc3e41c9acda3fe3b2abca635f995f18889d8f"}
Message was sent while issue was closed.
Description was changed from ========== Remove delay for the first JumpList top site sync in one session In current JumpList implementation, when the first tab is closed in one session, it doesn't trigger an update but a TopSites sync. This sync will then trigger an update for both mostly visited and recently closed categories. We don't need to delay this TopSites sync, otherwise it will take at least 7 seconds to get the JumpList refreshed after the first tab is closed in one session. BUG=733034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng ========== to ========== Remove delay for the first JumpList top site sync in one session In current JumpList implementation, when the first tab is closed in one session, it doesn't trigger an update but a TopSites sync. This sync will then trigger an update for both mostly visited and recently closed categories. We don't need to delay this TopSites sync, otherwise it will take at least 7 seconds to get the JumpList refreshed after the first tab is closed in one session. BUG=733034 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.win:win10_chromium_x64_rel_ng Review-Url: https://codereview.chromium.org/2965973002 Cr-Commit-Position: refs/heads/master@{#484446} Committed: https://chromium.googlesource.com/chromium/src/+/93fc3e41c9acda3fe3b2abca635f... ==========
Message was sent while issue was closed.
Committed patchset #1 (id:60001) as https://chromium.googlesource.com/chromium/src/+/93fc3e41c9acda3fe3b2abca635f... |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
