Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(174)

Issue 2965893002: Add new enum value for DircryptoMigrationEndStatus (Closed)

Created:
3 years, 5 months ago by dspaid
Modified:
3 years, 5 months ago
Reviewers:
hashimoto
CC:
chromium-reviews, asvitkine+watch_chromium.org
Target Ref:
refs/heads/master
Project:
chromium
Visibility:
Public.

Description

Add new enum value for DircryptoMigrationEndStatus Add an enum to indicate that the migration was cancelled (for example because the source filesystem was unmounted). BUG=733169 TEST=./validate_format.py && ./pretty_print.py Review-Url: https://codereview.chromium.org/2965893002 Cr-Commit-Position: refs/heads/master@{#483937} Committed: https://chromium.googlesource.com/chromium/src/+/9888d75c78ec81c6d402fe3ccb498165ecc79403

Patch Set 1 #

Total comments: 4

Patch Set 2 : Add new enum value for DircryptoMigrationEndStatus #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -0 lines) Patch
M tools/metrics/histograms/enums.xml View 1 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 11 (4 generated)
dspaid
ptal
3 years, 5 months ago (2017-07-03 01:23:50 UTC) #2
hashimoto
Oops, thank you for doing this! https://codereview.chromium.org/2965893002/diff/1/tools/metrics/histograms/enums.xml File tools/metrics/histograms/enums.xml (right): https://codereview.chromium.org/2965893002/diff/1/tools/metrics/histograms/enums.xml#newcode7836 tools/metrics/histograms/enums.xml:7836: + <int value="11" ...
3 years, 5 months ago (2017-07-03 02:33:46 UTC) #3
dspaid
https://codereview.chromium.org/2965893002/diff/1/tools/metrics/histograms/enums.xml File tools/metrics/histograms/enums.xml (right): https://codereview.chromium.org/2965893002/diff/1/tools/metrics/histograms/enums.xml#newcode7836 tools/metrics/histograms/enums.xml:7836: + <int value="11" label="New migrationed cancelled"/> On 2017/07/03 02:33:46, ...
3 years, 5 months ago (2017-07-03 03:24:54 UTC) #4
hashimoto
3 years, 5 months ago (2017-07-03 03:26:12 UTC) #5
hashimoto
lgtm
3 years, 5 months ago (2017-07-03 03:26:13 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at: https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2965893002/20001
3 years, 5 months ago (2017-07-03 03:26:52 UTC) #8
commit-bot: I haz the power
3 years, 5 months ago (2017-07-03 03:59:09 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/src/+/9888d75c78ec81c6d402fe3ccb49...

Powered by Google App Engine
This is Rietveld 408576698