Mojo JS bindings: add support to generate "dual-mode" code.

Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

TBR=brettw@chromium.org
(For the changes in url/mojo/BUILD.gn)

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2965803003
Cr-Commit-Position: refs/heads/master@{#484145}
Committed: https://chromium.googlesource.com/chromium/src/+/dc048bef86deaed860574f5d3a29b23f0c3e6c73

[yzshen1, 2017-06-30 21:54:20]

Description was changed from

==========
Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

BUG=699569
==========

to

==========
Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yzshen1, 2017-06-30 21:54:31]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 21:54:45]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-06-30 22:02:02]

The CQ bit was checked by yzshen@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-06-30 22:02:12]

Dry run: CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-06-30 22:04:09]

yzshen@chromium.org changed reviewers:
+ dpapad@chromium.org, rockot@chromium.org

[yzshen1, 2017-06-30 22:04:09]

Hi, 

Would you please take a look? Thanks!

Ken - mojo/
Demetrios - webui-related code

[dpapad, 2017-06-30 22:15:03]

WebUI LGTM with nit.

https://codereview.chromium.org/2965803003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/usb_internals/usb_internals.js (right):

https://codereview.chromium.org/2965803003/diff/20001/chrome/browser/resource...
chrome/browser/resources/usb_internals/usb_internals.js:64: initializeProxies();
Nit: Can we inline the contents of initializeProxies() here? I don't think it is
called anywhere else.

[Ken Rockot(use gerrit already), 2017-06-30 22:34:48]

lgtm

[yzshen1, 2017-06-30 22:37:11]

Description was changed from

==========
Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

TBR=brettw@chromium.org
(For the changes in url/mojo/BUILD.gn)

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[yzshen1, 2017-06-30 22:37:31]

Thanks!

https://codereview.chromium.org/2965803003/diff/20001/chrome/browser/resource...
File chrome/browser/resources/usb_internals/usb_internals.js (right):

https://codereview.chromium.org/2965803003/diff/20001/chrome/browser/resource...
chrome/browser/resources/usb_internals/usb_internals.js:64: initializeProxies();
On 2017/06/30 22:15:03, dpapad wrote:
> Nit: Can we inline the contents of initializeProxies() here? I don't think it
is
> called anywhere else.

Done.

[yzshen1, 2017-06-30 22:37:35]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-06-30 22:37:36]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2965803003/#ps40001
(title: ".")

[commit-bot: I haz the power, 2017-06-30 22:37:55]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Reilly Grant (use Gerrit), 2017-06-30 23:21:11]

reillyg@chromium.org changed reviewers:
+ reillyg@chromium.org

[Reilly Grant (use Gerrit), 2017-06-30 23:21:13]

chrome://usb-internals changes lgtm and I generally like the direction of this
patch though I got a little lost in the code generation parts.

[commit-bot: I haz the power, 2017-06-30 23:31:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-06-30 23:31:26]

Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[yzshen1, 2017-07-02 19:49:03]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-07-02 19:49:04]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
reillyg@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2965803003/#ps80001
(title: ".")

[commit-bot: I haz the power, 2017-07-02 19:49:10]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-02 20:18:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-02 20:18:42]

Try jobs failed on following builders:
  ios-device on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-device/builds...)

[yzshen1, 2017-07-03 17:34:17]

The CQ bit was checked by yzshen@chromium.org

[commit-bot: I haz the power, 2017-07-03 17:34:23]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[yzshen1, 2017-07-03 17:43:29]

The CQ bit was unchecked by yzshen@chromium.org

[yzshen1, 2017-07-03 17:44:10]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-07-03 17:44:10]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
reillyg@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2965803003/#ps100001
(title: ".")

[commit-bot: I haz the power, 2017-07-03 17:44:19]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-03 20:01:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-07-03 20:01:58]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[yzshen1, 2017-07-04 17:18:22]

The CQ bit was checked by yzshen@chromium.org

[yzshen1, 2017-07-04 17:18:22]

The patchset sent to the CQ was uploaded after l-g-t-m from rockot@chromium.org,
reillyg@chromium.org, dpapad@chromium.org
Link to the patchset: https://codereview.chromium.org/2965803003/#ps120001
(title: ".")

[commit-bot: I haz the power, 2017-07-04 17:18:35]

CQ is trying da patch.

Follow status at:
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-07-04 19:10:25]

CQ is committing da patch.

Bot data: {"patchset_id": 120001, "attempt_start_ts": 1499188702543610,
"parent_rev": "699fb5ef02326c0ae298c0f94b04cfd674da0668", "commit_rev":
"dc048bef86deaed860574f5d3a29b23f0c3e6c73"}

[commit-bot: I haz the power, 2017-07-04 19:10:42]

Description was changed from

==========
Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

TBR=brettw@chromium.org
(For the changes in url/mojo/BUILD.gn)

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
Mojo JS bindings: add support to generate "dual-mode" code.

Previously, if mojom target A and B both depend on C, in order to convert A to
the new mode, we need to convert C, and also all the targets that depend on C
(i.e., B).

With this CL, we could let target C generate code supporting both modes. That
way B don't have to be touched in the same CL.

TBR=brettw@chromium.org
(For the changes in url/mojo/BUILD.gn)

BUG=699569
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Review-Url: https://codereview.chromium.org/2965803003
Cr-Commit-Position: refs/heads/master@{#484145}
Committed:
https://chromium.googlesource.com/chromium/src/+/dc048bef86deaed860574f5d3a29...
==========

[commit-bot: I haz the power, 2017-07-04 19:10:44]

Committed patchset #7 (id:120001) as
https://chromium.googlesource.com/chromium/src/+/dc048bef86deaed860574f5d3a29...